Closed Bug 1475251 Opened 2 years ago Closed 2 years ago
HTTP auth dialog looks wrong
The HTTP auth dialog in Fennec has regressed sometime in the last few days. The username/password fields are one character wide now, instead of the width of the dialog. See attached screenshot. You can make one of these appear by going to https://bugmash.staktrace.com/dashboard.php
Version: 57 Branch → Firefox 63
Thanks Jan! Indeed seems to be a regression caused by bug 1412517. The easiest solution would be an instanceof check for the PromptInputs but I'll look for something better.
Assignee: nobody → petru.lingurar
Status: NEW → ASSIGNED
Comment on attachment 8992279 [details] Bug 1475251 - HTTP auth dialog looks wrong; https://reviewboard.mozilla.org/r/257164/#review264178
Attachment #8992279 - Flags: review?(nchen) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/02eefb5f33de HTTP auth dialog looks wrong; r=jchen
Status: RESOLVED → VERIFIED
Bug 1412517 wasn't uplifted to Beta, so it should be unaffected, shouldn't it?
Current beta (62.0b9) indeed looks unaffected on my device.
Verified in the latest Nightly and everything works as expected.
Comment on attachment 8992279 [details] Bug 1475251 - HTTP auth dialog looks wrong; Approval Request Comment [Feature/Bug causing the regression]: Bug 1412517 [User impact if declined]: The widget to allow entering text in input pickers only shows one character, it does not expand the full line making this process cumbersome. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: -- [List of other uplifts needed for the feature/fix]: [Is the change risky?]: No [Why is the change risky/not risky?]: Has been QE verified and in the time being in Nightly no issues have been reported. [String changes made/needed]: --
Attachment #8992279 - Flags: approval-mozilla-beta?
Comment on attachment 8992279 [details] Bug 1475251 - HTTP auth dialog looks wrong; One of several small fixes for the date picker related to the switch in 62 to using the platform library. Verified in nightly. Let's uplift for next Monday's beta 17 build.
Attachment #8992279 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Can you please check this, Levente?
Verified as fixed in 62 Beta 17. Working as expected on Sony Xperia Z5 (Android 7.0) & Samsung S8+ (Android 8.0.0)
You need to log in before you can comment on or make changes to this bug.