1475251 - HTTP auth dialog looks wrong

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot_20180712-101935.png

The HTTP auth dialog in Fennec has regressed sometime in the last few days. The username/password fields are one character wide now, instead of the width of the dialog. See attached screenshot. You can make one of these appear by going to https://bugmash.staktrace.com/dashboard.php

Comment 1

[Jan Henning [:JanH]]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=84683bf540a58f9d3db645550748e37c742991d6&tochange=5c13bf70a3e1bac455d93c136d8079ac3be022e9

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Thanks Jan!

Indeed seems to be a regression caused by bug 1412517.
The easiest solution would be an instanceof check for the PromptInputs but I'll look for something better.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1475251 - HTTP auth dialog looks wrong;

Specialized the code added in Bug 1412517 so that it will apply only for
date/time inputs. The rest will have the previous behaviour.

Review commit: https://reviewboard.mozilla.org/r/257164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257164/

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992279 [details]
Bug 1475251 - HTTP auth dialog looks wrong;

https://reviewboard.mozilla.org/r/257164/#review264178

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02eefb5f33de
HTTP auth dialog looks wrong; r=jchen

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/02eefb5f33de

Comment 8

[Jan Henning [:JanH]]

Bug 1412517 wasn't uplifted to Beta, so it should be unaffected, shouldn't it?

Comment 9

[Dan Callahan [:callahad]]

Current beta (62.0b9) indeed looks unaffected on my device.

Comment 10

[Bogdan Surd, QA [:bsurd, NI]]

Verified in the latest Nightly and everything works as expected.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8992279 [details]
Bug 1475251 - HTTP auth dialog looks wrong;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1412517
[User impact if declined]: The widget to allow entering text in input pickers only shows one character, it does not expand the full line making this process cumbersome.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No
[Why is the change risky/not risky?]: Has been QE verified and in the time being in Nightly no issues have been reported.
[String changes made/needed]: --

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8992279 [details]
Bug 1475251 - HTTP auth dialog looks wrong;

One of several small fixes for the date picker related to the switch in 62 to using the platform library. Verified in nightly. 
Let's uplift for next Monday's beta 17 build.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ea5b02a5d0ef

Comment 14

[Ioana Chiorean]

Can you please check this, Levente?

Comment 15

[Levente Sacal]

Verified as fixed in 62 Beta 17. Working as expected on Sony Xperia Z5 (Android 7.0) & Samsung S8+ (Android 8.0.0)