1475298 - [en-GB] 'Your connection is not secure alert' when searching using address bar with Chambers.

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Marc Walsh]

Attachment: Screen Shot 2018-07-12 at 17.54.06.png

I get the following alert saying 'Your connection is not secure' when I try to search using Chambers from the address bar when using the latest version of Nightly.

Error code: SSL_ERROR_BAD_CERT_DOMAIN

Comment 1

[Marc Walsh]

This is probably more of an issue on Chambers side:

When using https://www.chambers.co.uk - I get the error. When using https://chambers.co.uk I do not.

Comment 2

[Francesco Lodolo [:flod]]

For reference: Chambers is provided for en-GB
https://searchfox.org/mozilla-central/rev/a80651653faa78fa4dfbd238d099c2aad1cec304/browser/components/search/searchplugins/chambers-en-GB.xml

The search link is not using https
http://www.chambers.co.uk/search/

So they're redirecting and they're poorly configured. Changing the URL to https://chambers.co.uk/search/ should fix the issue.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1475298 - [en-GB] Switch URL to https for Chambers searchplugin

Review commit: https://reviewboard.mozilla.org/r/257144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257144/

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8992264 [details]
Bug 1475298 - [en-GB] Switch URL to https for Chambers searchplugin

https://reviewboard.mozilla.org/r/257144/#review264426

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9bae9762692
[en-GB] Switch URL to https for Chambers searchplugin r=mkaply

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d9bae9762692

Comment 7

[Francesco Lodolo [:flod]]

Verified on 63.0a1 (2018-07-18) (64-bit)

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8992264 [details]
Bug 1475298 - [en-GB] Switch URL to https for Chambers searchplugin

Approval Request Comment

[Feature/Bug causing the regression]: change on the website (switch to SSL) broke the existing searchplugin

[User impact if declined]: search on chambers.co.uk is broken 

[Is this code covered by automated tests?]: No

[Has the fix been verified in Nightly?]: Yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: No

[Why is the change risky/not risky?]: Secondary (non default) searchplugin, only affecting English (UK) builds

[String changes made/needed]: None

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8992264 [details]
Bug 1475298 - [en-GB] Switch URL to https for Chambers searchplugin

Fix to use https for a UK search plugin, let's take this for 62.

Comment 10

[Marc Walsh]

I tested this on 61.0.1 and it is also affected.

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Marc Walsh from comment #10)
> I tested this on 61.0.1 and it is also affected.

That's expected, since the issue was created on their side. But I don't think there's a lot of value in uplifting this kind of changes (secondary searchplugins) to release.

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a809afaea17