Closed Bug 1475300 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 11942 - [css-properties-values-api] Add tests for Typed OM reification.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11942 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11942
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Add tests for Typed OM reification.
>  
>  How registered custom properties are reified is currently not specified
>  [1]. For computed values, it should hopefully be pretty obvious how it
>  should work. (For declared/inline style it is less clear).
>  
>  This patch adds tests for the computed style only.
>  
>  Note:
>  
>   * <transform-function> is not tested, because it appears that this
>     syntax was re-added to the spec by mistake, so I expect support for
>     <transform-function> will be reverted.
>   * <transform-list> and list syntaxes in general are not tested, because
>     it's currently broken in Blink. Tests for list syntaxes will be added
>     along with the fix for that.
>  
>  [1] https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue
>  
>  R=chrishtr@chromium.org
>  
>  Bug: 641877
>  Change-Id: Ic177bfe2b90897ec44ef4405c745171d8b226e82
>  Reviewed-on: https://chromium-review.googlesource.com/1134778
>  WPT-Export-Revision: bbfb80a1c75ca2df4f4e8b1c0f57ff8945a4e744
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 16 subtests
OK     : 1
FAIL   : 16

New tests that have failures or other problems:
/css/css-properties-values-api/typedom.tentative.html
    Computed * is reified as CSSUnparsedValue: FAIL
    Computed <angle> is reified as CSSUnitValue: FAIL
    Computed <color> is reified as CSSStyleValue: FAIL
    Computed <custom-ident> is reified as CSSKeywordValue: FAIL
    Computed <image> [url] is reified as CSSImageValue: FAIL
    Computed <integer> is reified as CSSUnitValue: FAIL
    Computed <length-percentage> [%] is reified as CSSUnitValue: FAIL
    Computed <length-percentage> [px + %] is reified as CSSMathSum: FAIL
    Computed <length-percentage> [px] is reified as CSSUnitValue: FAIL
    Computed <length> is reified as CSSUnitValue: FAIL
    Computed <number> is reified as CSSUnitValue: FAIL
    Computed <percentage> is reified as CSSUnitValue: FAIL
    Computed <resolution> is reified as CSSUnitValue: FAIL
    Computed <time> is reified as CSSUnitValue: FAIL
    Computed <url> is reified as CSSStyleValue: FAIL
    Computed ident is reified as CSSKeywordValue: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/697e3146f3ac
[wpt PR 11942] - [css-properties-values-api] Add tests for Typed OM reification., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/06120610a5a3
[wpt PR 11942] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/697e3146f3ac
https://hg.mozilla.org/mozilla-central/rev/06120610a5a3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.