Closed Bug 1475305 Opened 6 years ago Closed 6 years ago

Remove document.width/document.height from XULDocument

Categories

(Core :: XUL, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

These are referenced only twice:

- once in a test (that is commented out of the test manifest file): 
- in some devtools drag/drop code

I believe both instances should be replacable by document.documentElement.client[Width|Height]

https://searchfox.org/mozilla-central/search?q=document.width&path=
https://searchfox.org/mozilla-central/search?q=document.height&path=
Comment on attachment 8991705 [details]
Bug 1475305 - Remove document.width and document.height from XULDocument;

https://reviewboard.mozilla.org/r/256640/#review263490

Please get the mdn docs updated, and deal with the links to them in devtools/client/sourceeditor/tern/browser.js ?

Also please file a comm-central bug to fix their uses.  There are uses in suite/browser/tabbrowser.xml, mail/components/accountcreation/content/emailWizard.js, calendar/base/content/dialogs/calendar-dialog-utils.js
Attachment #8991705 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #2)
> Please get the mdn docs updated, and deal with the links to them in
> devtools/client/sourceeditor/tern/browser.js ?

I believe those links and type definitions in Tern are actually built from MDN docs, so we'll need wait for an update upstream instead of directly tweaking the browser.js file. I'll confirm though before landing.
Keywords: dev-doc-needed
(In reply to Brian Grinstead [:bgrins] from comment #3)
> (In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from
> comment #2)
> > Please get the mdn docs updated, and deal with the links to them in
> > devtools/client/sourceeditor/tern/browser.js ?
> 
> I believe those links and type definitions in Tern are actually built from
> MDN docs, so we'll need wait for an update upstream instead of directly
> tweaking the browser.js file. I'll confirm though before landing.

Based on the history of https://github.com/ternjs/tern/commits/master/defs/browser.json it looks like the updates are fairly manual.
Depends on: 1475343
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c51921a6582
Remove document.width and document.height from XULDocument;r=bz
https://hg.mozilla.org/mozilla-central/rev/6c51921a6582
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
To fix the docs, I just wanted to check what you think needs to be done here? the links you've got to Document.width and Document.height redirect to their current locations:

https://developer.mozilla.org/en-US/docs/Web/API/Document/width
https://developer.mozilla.org/en-US/docs/Web/API/Document/height

In both cases we say clearly that they aren't supported anymore, and what you should do instead.

But if they are not supported anywhere, I could probably just delete those pages. Would that fix your issue?
Flags: needinfo?(bgrinstead)
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #7)
> To fix the docs, I just wanted to check what you think needs to be done
> here? the links you've got to Document.width and Document.height redirect to
> their current locations:
> 
> https://developer.mozilla.org/en-US/docs/Web/API/Document/width
> https://developer.mozilla.org/en-US/docs/Web/API/Document/height
> 
> In both cases we say clearly that they aren't supported anymore, and what
> you should do instead.
> 
> But if they are not supported anywhere, I could probably just delete those
> pages. Would that fix your issue?

Whatever the MDN policy is for unsupported features like this is fine with me (either leaving as-is or deleting the pages). These haven't worked for web content for a really long time, but I guess they used to up until Gecko 6.0 according to the page. This bug removed them from chrome as well.
Flags: needinfo?(bgrinstead)
(In reply to Brian Grinstead [:bgrins] from comment #8)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #7)
> > To fix the docs, I just wanted to check what you think needs to be done
> > here? the links you've got to Document.width and Document.height redirect to
> > their current locations:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/API/Document/width
> > https://developer.mozilla.org/en-US/docs/Web/API/Document/height
> > 
> > In both cases we say clearly that they aren't supported anymore, and what
> > you should do instead.
> > 
> > But if they are not supported anywhere, I could probably just delete those
> > pages. Would that fix your issue?
> 
> Whatever the MDN policy is for unsupported features like this is fine with
> me (either leaving as-is or deleting the pages). These haven't worked for
> web content for a really long time, but I guess they used to up until Gecko
> 6.0 according to the page. This bug removed them from chrome as well.

I think I'll leave them for now, if that's OK. It's pretty clear that they are not supported, and there will be some web archeologists out there that still care about this stuff from a historical perspective.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: