1475335 - Perma TestInjectEject.CreateRemoteThread_LoadLibraryA | Value of: !"Thread was allowed but should have been blocked." when Gecko 63 merges to Beta on 2018-08-27

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Windows debug GTest fails in beta simulations:

Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d22fc10a708adcfb7fca6ee3a7bbd19caba63cd&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=187844090

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=187844090&repo=try

14:33:24     INFO -  TEST-START | TestInjectEject.CreateRemoteThread_LoadLibraryA
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryA | Value of: !"Thread was allowed but should have been blocked."
14:33:24     INFO -    Actual: false
14:33:24     INFO -  Expected: true @ z:/build/build/src/mozglue/tests/gtest/TestDLLEject.cpp:173
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryA | test completed (time: 23ms)
14:33:24     INFO -  TEST-START | TestInjectEject.CreateRemoteThread_LoadLibraryW
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryW | Value of: !"Thread was allowed but should have been blocked."
14:33:24     INFO -    Actual: false
14:33:24     INFO -  Expected: true @ z:/build/build/src/mozglue/tests/gtest/TestDLLEject.cpp:173
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryW | test completed (time: 9ms)
14:33:24     INFO -  TEST-START | TestInjectEject.CreateRemoteThread_LoadLibraryExW
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryExW | Value of: !"Thread was allowed but should have been blocked."
14:33:24     INFO -    Actual: false
14:33:24     INFO -  Expected: true @ z:/build/build/src/mozglue/tests/gtest/TestDLLEject.cpp:173
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryExW | test completed (time: 10ms)
14:33:24     INFO -  TEST-START | TestInjectEject.CreateRemoteThread_LoadLibraryExA
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryExA | Value of: !"Thread was allowed but should have been blocked."
14:33:24     INFO -    Actual: false
14:33:24     INFO -  Expected: true @ z:/build/build/src/mozglue/tests/gtest/TestDLLEject.cpp:173
14:33:24  WARNING -  TEST-UNEXPECTED-FAIL | TestInjectEject.CreateRemoteThread_LoadLibraryExA | test completed (time: 9ms)

Comment 1

[Carl Corcoran [:ccorcoran]]

Attachment: Bug 1475335: Restrict TestInjectEject gtests to nightly builds;

Review commit: https://reviewboard.mozilla.org/r/256844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256844/

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8991934 [details]
Bug 1475335: Restrict TestInjectEject gtests to nightly builds;

https://reviewboard.mozilla.org/r/256844/#review264212

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69bc78190350
Restrict TestInjectEject gtests to nightly builds;r=aklotz

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/69bc78190350

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with the latest beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d4534b88c19b53b1fe35e74e5e8c632103f0ef6&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 6

[Masatoshi Kimura [:emk]]

Why is it OK to restrict this test to Nightly? Doesn't it mean that the DLL injector is broken in beta or release?

Comment 7

[Carl Corcoran [:ccorcoran]]

The test is restricted to Nightly because the feature itself (bug 1435816) is restricted to Nightly. We've been putting features like this on Nightly as a way to reduce impact before a larger roll out. It may be a good time to un-restrict this feature though; I've filed bug 1481454