Closed
Bug 1475351
Opened 6 years ago
Closed 6 years ago
Crash with stylesheets in shadow dom
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: potch, Assigned: emilio)
References
()
Details
(Keywords: crash, Whiteboard: [tbird crash])
Crash Data
Attachments
(1 file)
|
3.06 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
Working on a demo, getting relatively consistent crashing while working with it. Crashes have occurred on page load and while running performance devtools.
|
||
Comment 2•6 years ago
|
||
So far no luck reproducing. And in crash-stats.mozilla.com I see very similar crashes on 52 Thunderbird. Somehow we have null mSheet
No longer blocks: shadowdom-initial-release
|
Assignee | |
Comment 4•6 years ago
|
||
I couldn't repro either... Any reliable str Potch? SheetLoadData::mSheet is not supposed to be null...
|
Reporter | |
Comment 5•6 years ago
|
||
I can't think of reliable str, I'm working with the example code (making changes, refreshing, profiling) and I lose the tab relatively frequently. No crashes on my nightly outside of this. The following reports are all from working with the above demo: https://crash-stats.mozilla.com/report/index/bp-ca73d3cb-a3b4-4eba-88c0-ef4580180712 https://crash-stats.mozilla.com/report/index/bp-6066e7a3-23c1-4005-a682-dda1b0180712 https://crash-stats.mozilla.com/report/index/bp-51a48b50-30f0-48d8-a199-d91e40180712 https://crash-stats.mozilla.com/report/index/bp-257341e4-82e3-4f38-abec-4fb6e0180712 https://crash-stats.mozilla.com/report/index/bp-450e6a80-bbc8-45b8-beaf-557960180711 https://crash-stats.mozilla.com/report/index/bp-62a79a01-64b1-4314-9b35-588d30180711
Flags: needinfo?(thepotch)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Ah, I managed to repro with the inspector open.
Assignee: nobody → emilio
|
|
Assignee | |
Comment 7•6 years ago
|
||
Olli reviewed this over IRC while Bugzilla was down yesterday.
Flags: needinfo?(emilio)
Attachment #8992185 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/1ea3747437b7 Properly clear associated ShadowRoot from StyleSheet objects. r=smaug
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1ea3747437b7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
Crash Signature: mozilla::StyleSheet::SetComplete → [@ mozilla::StyleSheet::SetComplete ]
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•