1475355 - WebRender qualified includes laptops

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

The intention was to only target desktop at the start. We can either look at the individual GPUs or we could probably use GetSystemPowerStatus() to just ensure that there's no battery.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1475355. Only use WebRender if there's no battery.

Review commit: https://reviewboard.mozilla.org/r/257276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257276/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8992399 [details]
Bug 1475355. Only use WebRender if there's no battery.

https://reviewboard.mozilla.org/r/257276/#review264088

::: gfx/thebes/gfxPlatform.cpp:2551
(Diff revision 1)
> + * For now we'd rather err on the side of thinking we do. */
> +static bool HasBatttery()
> +{
> +  SYSTEM_POWER_STATUS status;
> +  const BYTE NO_SYSTEM_BATTERY = 128;
> +  if (GetSystemPowerStatus(&status)) {

Doesn't this need to be inside an #ifdef XP_WIN block?

Comment 3

[Darkspirit]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Doesn't this need to be inside an #ifdef XP_WIN block?

bug 1455696 forbids Intel, AMD and ATI on Windows, but not Microsoft, Parallels and Qualcomm.
https://searchfox.org/mozilla-central/rev/6f86cc3479f80ace97f62634e2c82a483d1ede40/widget/GfxDriverInfo.h#107,109-110
Could this mean that gfx.webrender.all.qualified;true works on Win10 on "Parallels Desktop for Mac"?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

That's seems like a reasonable interpretation. We should do better.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8992399 [details]
Bug 1475355. Only use WebRender if there's no battery.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257276/diff/1-2/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8992399 [details]
Bug 1475355. Only use WebRender if there's no battery.

https://reviewboard.mozilla.org/r/257276/#review264550

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/162af260bace
Only use WebRender if there's no battery. r=kats

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/162af260bace