Closed Bug 1475355 Opened Last year Closed Last year

WebRender qualified includes laptops

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

The intention was to only target desktop at the start. We can either look at the individual GPUs or we could probably use GetSystemPowerStatus() to just ensure that there's no battery.
Comment on attachment 8992399 [details]
Bug 1475355. Only use WebRender if there's no battery.

https://reviewboard.mozilla.org/r/257276/#review264088

::: gfx/thebes/gfxPlatform.cpp:2551
(Diff revision 1)
> + * For now we'd rather err on the side of thinking we do. */
> +static bool HasBatttery()
> +{
> +  SYSTEM_POWER_STATUS status;
> +  const BYTE NO_SYSTEM_BATTERY = 128;
> +  if (GetSystemPowerStatus(&status)) {

Doesn't this need to be inside an #ifdef XP_WIN block?
Attachment #8992399 - Flags: review?(bugmail)
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> Doesn't this need to be inside an #ifdef XP_WIN block?

bug 1455696 forbids Intel, AMD and ATI on Windows, but not Microsoft, Parallels and Qualcomm.
https://searchfox.org/mozilla-central/rev/6f86cc3479f80ace97f62634e2c82a483d1ede40/widget/GfxDriverInfo.h#107,109-110
Could this mean that gfx.webrender.all.qualified;true works on Win10 on "Parallels Desktop for Mac"?
That's seems like a reasonable interpretation. We should do better.
Priority: -- → P1
Whiteboard: [gfx-noted]
Assignee: nobody → jmuizelaar
Comment on attachment 8992399 [details]
Bug 1475355. Only use WebRender if there's no battery.

https://reviewboard.mozilla.org/r/257276/#review264550
Attachment #8992399 - Flags: review?(bugmail) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/162af260bace
Only use WebRender if there's no battery. r=kats
https://hg.mozilla.org/mozilla-central/rev/162af260bace
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.