1475390 - Fail configure if the Tup backend is specified on a platform other than Linux

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

We don't want people to waste time trying to get tup set up on Windows or Linux yet.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester (:chmanchester) from comment #0)
> We don't want people to waste time trying to get tup set up on Windows or
> Linux yet.

Of course I mean Windows or macOS.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1475390 - Fail configure if Tup is specified on a non-linux build.

Review commit: https://reviewboard.mozilla.org/r/256988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256988/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8992103 [details]
Bug 1475390 - Fail configure if Tup is specified on a non-linux build.

https://reviewboard.mozilla.org/r/256988/#review263836

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3eb58b5214a
Fail configure if Tup is specified on a non-linux build. r=gps

Comment 5

[Code Review Bot [:reviewbot]]

Comment on attachment 8992103 [details]
Bug 1475390 - Fail configure if Tup is specified on a non-linux build.

https://reviewboard.mozilla.org/r/256988/#review263842


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: build/moz.configure/tup.configure:58
(Diff revision 1)
>      min_rustc_version = Version('1.28.0')
>      if tup and rustc_info.version < min_rustc_version:
>          die('Cannot build with tup and rustc %s. please update to at least '
>              'rustc %s to continue.', rustc_info.version, min_rustc_version)
>  
> +@depends(tup, target, build_project)

Error: Expected 2 blank lines, found 1 [flake8: E302]

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b3eb58b5214a