1475438 - [a11y] Expose status of job by some means other than colour

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[James Teh [:Jamie]]

At present, the status of jobs (.job-btn) is only exposed through colour (green for success, etc.). In addition to colour, the status should also be exposed in another way.

A simple way this could be done is to add it to the information in the title attribute. Right now, that includes the name of the job and how long it took, but not the status. I'm pretty sure it *did* expose the status a while ago, but it doesn't any more.

Impact: This makes it extremely difficult for me as a blind Mozilla developer to gauge the status of a job without opening it or filtering to only show jobs with a single status.

Comment 1

[Paul Bone [:pbone]]

In the past I suggested that jobs be arranged into a table based on their status.  Incomplete jobs on the right, moving to columns on the left for success/failure/etc.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3793

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This adds the following to the beginning of the job button tooltip:

"[$STATE] | "

So for instance, a full title string for a successfully completed job could be "[success] | build-linux64-fuzzing/debug -  (29 mins)".

Would this improve things for you?

Comment 4

[James Teh [:Jamie]]

(In reply to Wes Kocher (:KWierso) from comment #3)
> This adds the following to the beginning of the job button tooltip:
> "[$STATE] | "
> So for instance, a full title string for a successfully completed job could
> be "[success] | build-linux64-fuzzing/debug -  (29 mins)".
> Would this improve things for you?

Absolutely; so much. Ideally, I'd like to come up with something else as well, as accessing the title still requires specific interaction from the user (as opposed to just seeing a colour), but this is a very good start. if I think of another possibility, I'll file a new bug for it.

Btw, I think the " | " might be redundant, since the status is in square brackets. Personally, I'd strip either the brackets or the "|" (the former preferred), as it reduces verbosity. However, I totally understand if this is better visually for some reason.

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8992549 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3793

I took the liberty of removing the square brackets from this change myself.  Thanks again for the PR, Wes!

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8992549 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3793

Commented in the PR.  I was premature in r+'ing this.  My bad.  Thanks Wes!

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/33bb723a56630b9eb2154e4994b257d236e36b6d
Bug 1475438 - Add the job result/status to the job button's title attribute (#3793)

This somewhat improves the accessibility of Treeherder for blind users, as a screen reader can read the title attribute, and the user doesn't need to open each log to find the status.

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 8992549 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3793

Thanks Wes!

Comment 10

[Cameron Dawson [:camd]]

Closing as fixed for now.  But please open a new bug with suggestions if there's something else that would improve this.

Unfortunately, separating jobs into the different results would greatly increase the amount of screen real-estate that's needed to display pushes.  It is my impression that would make the Sheriff's jobs harder.  An alternate view at some point may be possible, however.  But we'd have to spec'ed-out and prioritized with our other work.