Closed Bug 1475515 Opened 3 years ago Closed 3 years ago

Remove member initialization for union Extra::mMessage

Categories

(Core :: DOM: Bindings (WebIDL), enhancement)

Product:
Core
Component:
DOM: Bindings (WebIDL)
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(1 file)

Bug 1475515 - Remove member initialization for union Extra::mMessage.
59 bytes, text/x-review-board-request
bzbarsky
: review+
Details 
As :bz commented in bug 1453795 we shouldn't initialize mMessage in the ctor on Extra.
Instead, in order to keep the static-analysis happy, we can ignore all of the member variables from Extra for initialization.
Summary: Remove member initialization from union Extra::mMessage → Remove member initialization for union Extra::mMessage
Comment on attachment 8991870 [details]
Bug 1475515 - Remove member initialization for union Extra::mMessage.

https://reviewboard.mozilla.org/r/256790/#review263838

r=me.  Thank you!
Attachment #8991870 - Flags: review?(bzbarsky) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03ecdc85a126
Remove member initialization for union Extra::mMessage. r=bz
https://hg.mozilla.org/mozilla-central/rev/03ecdc85a126
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.