Closed Bug 1475553 Opened 7 years ago Closed 7 years ago

Ensure all marker payloads have a type

Categories

(Core :: Gecko Profiler, enhancement, P2)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: gregtatum, Assigned: canova)

References

Details

Attachments

(1 file)

Bug 1475553 - Add type field to all markers that doesn't have before r?gregtatum
46 bytes, text/x-phabricator-request
gregtatum
: review+
Details | Review
In perf.html, we often work with marker payloads independent of their marker entries. In order to correctly identify the payload type, we need to ensure that every marker has a "type" field. This should be done on the Gecko Profiler. See: https://github.com/devtools-html/perf.html/issues/1131 Right now the VsyncTimestamp does not have one, but we should check the others too. See: https://searchfox.org/mozilla-central/rev/46292b1212d2d61d7b5a7df184406774727085b8/tools/profiler/core/ProfilerMarkerPayload.cpp#127-134
Priority: -- → P2
Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
Also opened a PR on perf.html side. Please see the link below.
See Also: → https://github.com/devtools-html/perf.html/pull/1244
Comment on attachment 9006868 [details] Bug 1475553 - Add type field to all markers that doesn't have before r?gregtatum Greg Tatum [:gregtatum] has approved the revision.
Attachment #9006868 - Flags: review+
Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/88d5ebc270c1 Add type field to all markers that doesn't have before r=gregtatum
https://hg.mozilla.org/mozilla-central/rev/88d5ebc270c1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: