1475558 - Remove annotations expiration policies to speed up expiration and removals

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Marco Bonardo [:mak]]

We do a bunch of work we don't need anymore, because annotations are going away and the only 2 policies we still use are EXPIRE_WITH_HISTORY and EXPIRE_NEVER.

When moving download annotations to history we'll likely also change those to EXPIRE_NEVER, because the only case where those 2 policies differ is if the page is bookmarked, and if the page is bookmarked we assume the user visited it sooner or later, so privacy is less of a concern.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1475558 - Remove annotations expiration policies to speed up expiration and removals. r=standard8

Remove expiration policies from annotations, keeping only EXPIRE_NEVER. Remove all the code handling expiration of those. Fix tests to pass proper arguments.

Comment 2

[Phabricator Automation]

Comment on attachment 8991978 [details]
Bug 1475558 - Remove annotations expiration policies to speed up expiration and removals. r=standard8

Mark Banner (:standard8) has approved the revision.

https://phabricator.services.mozilla.com/D2128

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2ed8429e90b
Remove annotations expiration policies to speed up expiration and removals. r=Standard8

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a2ed8429e90b