Closed Bug 1475598 Opened Last year Closed Last year

Windows signing task always fails on try-comm-central

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 63.0

People

(Reporter: jorgk-bmo, Unassigned)

Details

Attachments

(1 file, 2 obsolete files)

From Tom via IRC:

diff --git .taskcluster.yml .taskcluster.yml
--- .taskcluster.yml
+++ .taskcluster.yml
@@ -108,7 +108,8 @@ tasks:
               TASKCLUSTER_CACHES: /builds/worker/checkouts
             - $if: 'tasks_for != "action"'
               then:
-                COMM_COMMIT_MSG: '${push.comment}'
+                # See bug 1475598
+                GECKO_COMMIT_MSG: '${push.comment}'
             - $if: 'tasks_for == "action"'
               then:
                 ACTION_TASK_GROUP_ID: '${ownTaskId}'
It probably makes sense to just make this change (with a comment pointing to scriptworker about how it looks for that variable), and then also change the place that refers to it further down.
Flags: needinfo?(mozilla)
Attached patch 1475598.patch (obsolete) — Splinter Review
Sorry Tom, I can't make any sense of your comment #2.

"comment pointing to scriptworker" and "place that refers to it further down"??

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bd6bbef977281e5576b2b0e082487b73e623a677
Attachment #9000170 - Flags: review?(mozilla)
Looks like with this patch no jobs run at all :-(
- `COMM_COMMIT_MSG` is referred to elsewhere.
- Rather than having a comment pointing at this bug, have a comment something like 'scriptworker expects an environment variable named GECKO_* (link to code)'
Attached patch 1475598.patch (v2) (obsolete) — Splinter Review
(In reply to Tom Prince [:tomprince] from comment #5)
> - `COMM_COMMIT_MSG` is referred to elsewhere.
I don't understand how I missed that :-(

> - Rather than having a comment pointing at this bug, have a comment
> something like 'scriptworker expects an environment variable named GECKO_*
> (link to code)'
Sorry, I can't see GECKO_COMMIT_MSG anywhere in Mozilla code other than in M-C's .taskcluster.yml. So I can't add a link to it.
Attachment #9000170 - Attachment is obsolete: true
Attachment #9000170 - Flags: review?(mozilla)
Attachment #9001345 - Flags: review?(mozilla)
(In reply to Jorg K (GMT+2) from comment #6)
> Sorry, I can't see GECKO_COMMIT_MSG anywhere in Mozilla code other than in
> M-C's .taskcluster.yml. So I can't add a link to it.
Grrrr, it's in comment #0.
Attachment #9001345 - Attachment is obsolete: true
Attachment #9001345 - Flags: review?(mozilla)
Attachment #9001347 - Flags: review?(mozilla)
Attachment #9001347 - Flags: review?(mozilla) → review+
Component: Release Automation: Other → Build Config
Product: Release Engineering → Thunderbird
QA Contact: sfraser
Version: unspecified → Trunk
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9b1ad998de16
make signed Windows builds work on try-comm-central. r=tomprince
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
You need to log in before you can comment on or make changes to this bug.