1475610 - Unhandled error in async rendering when rendering is already in progress

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, enhancement, P3)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
Several times a week, the render_document async task fails, because the Document already has a render in progress.

What happened?
==============
The Document.render task raises a DocumentRenderingInProgress exception. The task attempts to email this to admins, which fails to render as an email.

What should have happened?
==========================
The async task should not attempt to render a document that is already in progress, or should handle this exception. The task should also not attempt to email admins, but instead should log exceptions to Sentry (bug 1428086).

Is there anything else we should know?
======================================

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/2ea0f9c002d2e4684dc3dee889ff5bd47c4ef9dc
bug 1475610: Handle DocumentRenderingInProgress

Do not attempt to email admins when a DocumentRenderingInProgress
exception is raised by the render function.

Also, pass the string version of the exception to mail_admins.

https://github.com/mozilla/kuma/commit/e45937d93bc2939fe82b4e7914b27b5cb1536cfa
Merge pull request #5003 from jwhitlock/rendering-task-1475610

bug 1475610: Handle DocumentRenderingInProgress

Comment 2

[John Whitlock [:jwhitlock]]

This code is live in production, and the errors have been silenced. The new issues are bug 1500766 (MySQL server has gone away) and bug 1500769 (DNS lookup failure for database).