1475612 - LSBUtils double closes a file descriptor on a background thread

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Kris Maglione [:kmag]]

LSBUtils calls close on a file descriptor that it has already closed with fclose. And since it does this on a background thread, it races with code that opens files on the main thread, and leads to weird breakage.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1475612: Fix double file close on background thread.

LSBUtils closes a file descriptor twice, once with fclose and then again with
close. It also does this on a background thread, during startup, which means
it tends to race with main thread code which opens files.

This patch fixes that, and also removes a work-around for the issue in the
MemMapSnapshot code.

Review commit: https://reviewboard.mozilla.org/r/256882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256882/

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8991980 [details]
Bug 1475612: Fix double file close on background thread.

https://reviewboard.mozilla.org/r/256882/#review263774

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a299ae02fc4c0a7c507e4410c28414a9fdb25b90
Bug 1475612: Fix double file close on background thread. r=erahm

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a299ae02fc4c