1475644 - Don't send URL in GeckoView crashes

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We're accidentally doing this right now.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1475644 - Don't send URL in GeckoView crash reports

Review commit: https://reviewboard.mozilla.org/r/256890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256890/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992000 [details]
Bug 1475644 - Don't send URL in GeckoView crash reports

https://reviewboard.mozilla.org/r/256890/#review263790

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/449887ba75e3
Don't send URL in GeckoView crash reports r=jchen

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/449887ba75e3

Comment 5

[Chris Peterson [:cpeterson]]

Comment on attachment 8992000 [details]
Bug 1475644 - Don't send URL in GeckoView crash reports

Approval Request Comment
[Feature/Bug causing the regression]: This is old code.
[User impact if declined]: Focus+GeckoView's crash reports will include users' URLs. The crash reports still do include other potential PII like memory dumps.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: The fix landed on GV Nightly two days ago, but it has not been manually tested by QA or Focus Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Not risky because it is a tiny patch and only affects GeckoView code, not Fennec.
[String changes made/needed]: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8992000 [details]
Bug 1475644 - Don't send URL in GeckoView crash reports

Privacy fix for geckoview, let's get this into beta 10.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2cb21e6a62f8

Comment 8

[Chris Peterson [:cpeterson]]

James, why did we stop including URLs in GV crash reports when we include them in desktop crash reports? Because GV crash reporting was enabled by default?

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Chris Peterson [:cpeterson] from comment #8)
> James, why did we stop including URLs in GV crash reports when we include
> them in desktop crash reports? Because GV crash reporting was enabled by
> default?

Do we send them in desktop reports? In Fennec it has always been opt-in.

And yes, GV crash reporting is enabled by default in Focus. We could add URLs in some opt-in "enhanced" bug reporting, maybe?

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #9)
> Do we send them in desktop reports? In Fennec it has always been opt-in.

Desktop reports do include URLs, but desktop Firefox also prompts the user before submitting each report. Basic crash report info are visible to anyone browsing crash-stats.m.o, but the URLs and memory dumps are only available for users with special crash-stats permissions.

> And yes, GV crash reporting is enabled by default in Focus. We could add
> URLs in some opt-in "enhanced" bug reporting, maybe?

I'm working with the Mozilla Data Stewards (in bug 1480260) to review our default settings now that we have both Sentry and Breakpad/Socorro crash reports. Sentry does not include PII, but Breakpad includes stack memory which might contain PII.