1475645 - Adjust sync-tests.sh script to unprefix "-moz-min-content" / "-moz-max-content" in w3c-submitted reftests

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Daniel Holbert [:dholbert]]

In bug 1474663, we'll be adding some reftests that use the "-moz-min-content" and "-moz-max-content" keywords (which we only support in their prefixed form, see bug 1322780).

We'd like for sync-tests.sh to automatically unprefix those when submitting them upstream.  Morgan, mind adjusting the sed command in sync-tests.sh to do this? 

(See the removed section in bug 1475385 for an example, and be sure you're basing your changes on top of that bug's patch, e.g. by pulling from autoland before starting to edit sync-tests.sh , or by waiting for that bug to be merged to central.)

Comment 1

[Daniel Holbert [:dholbert]]

Also, per bug 1475385 comment 7 / 8, it sounds like the most efficient thing to do here (to unblock the landing of your tests in bug 1474663 ASAP) is:

 (1) Wait for TYLin's changes (bug 1475385) to be sync'ed to the github wpt repo, here:
https://github.com/web-platform-tests/wpt/blob/master/css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests.sh
 (i.e. wait until that ^^ file doesn't have any mention of "column")

 (2) submit a pull request to that ^^ file on gitub (just using the web "pencil" editor if you like), to add sed replacement commands for -moz-min-content and -moz-max-content

 (3) After that pull request has been merged, we can close this bug and consider your tests on bug 1474663 landable. (i.e. at that point dbaron would be able to immediately synchronize them to a git clone of web-platform-tests, using his sync-tests.sh script in that clone, without any problems)

Comment 2

[Morgan Reschenberg [:morgan]]

Okay, I'll wait for it to sync. I drafted the changes in mozreview already so should be a quick fix when it all gets updated.

Comment 3

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1475645 - Update script to rename min-/max-content keywords in w3 tests.

Review commit: https://reviewboard.mozilla.org/r/256958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256958/

Comment 4

[Daniel Holbert [:dholbert]]

The change looks good to me!

For crafting the pull request (once TYLin's changes have synced), see earlier changes in https://github.com/web-platform-tests/wpt/commits/master/css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests.sh -- looks like you won't need to bother with the "bug NNN: ... r=whoever" syntax. Just describe the change (though if you like you could include a link to this bug (w/ the full bugzilla.mozilla.org URL) in the body of the pull request)

Comment 5

[Morgan Reschenberg [:morgan]]

PR drafted, waiting review (https://github.com/web-platform-tests/wpt/pull/11995)