Closed Bug 1475724 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11967 - HTMLBaseElement::href changed to accept TrustedTypes

Categories

(Core :: DOM: Security, enhancement, P4)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog]) 

Sync web-platform-tests PR 11967 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11967
Details from upstream follow.

Maja Kabus <kabusm@google.com> wrote:
>  HTMLBaseElement::href changed to accept TrustedTypes
>  
>  Changed implementation of setHref(), older version is abandoned.
>  Added href() getter that accepts URLString as an argument.
>  
>  Bug: 739170
>  Change-Id: I7703c1a33f037a912f1a105d8c79ef8fe5b4a289
>  Reviewed-on: https://chromium-review.googlesource.com/1136544
>  WPT-Export-Revision: 3508107aafe10041cb08474886f2fa770d51daa9
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Whiteboard: [wptsync downstream][domsecurity-backlog] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Ran 2 tests and 6 subtests
OK     : 2
FAIL   : 6

New tests that have failures or other problems:
/trusted-types/HTMLBaseElement-href.tentative.html
    base.href = URLS.safe, TrustedURL.create: FAIL
    base.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
/trusted-types/block-string-assignment-to-HTMLBaseElement-href.tentative.html
    `base.href = null` throws: FAIL
    `base.href = string` throws: FAIL
    base.href = URLS.safe, TrustedURL.create: FAIL
    base.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a71174fc706a
[wpt PR 11967] - HTMLBaseElement::href changed to accept TrustedTypes, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f7d29e85f66
[wpt PR 11967] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/a71174fc706a
https://hg.mozilla.org/mozilla-central/rev/7f7d29e85f66
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.