Closed
Bug 1475729
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11969 - Reland "Correctly initialize and test SnapContainerData in cc."
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11969 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11969 Details from upstream follow. Sandra Sun <sunyunjia@chromium.org> wrote: > Reland "Correctly initialize and test SnapContainerData in cc." > > This reverts commit 0fc70abb02f52598f0f98eafd7001490545bc0c9. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Correctly initialize and test SnapContainerData in cc." > > > > This reverts commit 37061f875b167ab82f1a0ddca84b510b7c6802dc. > > > > Reason for revert: > > The layout tests added by this CL is failing on the CL: > > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804 > > > > Original change's description: > > > Correctly initialize and test SnapContainerData in cc. > > > > > > This patch initializes the rect_ field in SnapContainerData in copy > > > constructor and move constructor. Fixing a snapping issue in the > > > composited pages. > > > > > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded > > > test suite so that they are tested with the composited cases. > > > > > > snap-at-user-scroll-end-manual-automation.js calls > > > mouseClickInTarget() of pointerevent_common_input.js. That method > > > invokes programmatic scrolls. The test was written before programmatic > > > scroll snapping was implemented so it worked at that time. However, > > > with programmatic scroll snapping implemented, it will always snap > > > in mouseClickIntarget() and cannot test whether the user scroll snaps. > > > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget > > > to avoid invoking programmatic scrolls in the test. > > > > > > This patch also checks nullptr for layout_box in > > > ScrollManager::SnapAtGestureScrollEnd() to fix a crash. > > > > > > Bug: 862406, 862571 > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e > > > Reviewed-on: https://chromium-review.googlesource.com/1132386 > > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > > Reviewed-by: Robert Flack <flackr@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#574781} > > > > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org > > > > Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 862406, 862571 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Reviewed-on: https://chromium-review.googlesource.com/1136171 > > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#574825} > > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org > > Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 862406, 862571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Reviewed-on: https://chromium-review.googlesource.com/1136671 > WPT-Export-Revision: af416855940bb0bd7d4bb257a1e6e4386268c9c7
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ca3e0b827924362bdae2c88e30ccc68093ac5d8
Assignee | ||
Comment 2•6 years ago
|
||
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/85d6fde07887 [wpt PR 11969] - Reland "Correctly initialize and test SnapContainerData in cc.", a=testonly
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/85d6fde07887
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•