1475737 - [wpt-sync] Sync PR 11972 - Revert "Reland "Correctly initialize and test SnapContainerData in cc.""

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11972 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11972
Details from upstream follow.

Sandra Sun <[e-mail]> wrote:
>  Revert "Reland "Correctly initialize and test SnapContainerData in cc.""
>  
>  This reverts commit 043b97cee41154a32d6c1cd8965075813a9ba672.
>  
>  Reason for revert: <INSERT REASONING HERE>
>  
>  Original change's description:
>  > Reland "Correctly initialize and test SnapContainerData in cc."
>  > 
>  > This reverts commit 0fc70abb02f52598f0f98eafd7001490545bc0c9.
>  > 
>  > Reason for revert: <INSERT REASONING HERE>
>  > 
>  > Original change's description:
>  > > Revert "Correctly initialize and test SnapContainerData in cc."
>  > > 
>  > > This reverts commit 37061f875b167ab82f1a0ddca84b510b7c6802dc.
>  > > 
>  > > Reason for revert:
>  > > The layout tests added by this CL is failing on the CL:
>  > > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
>  > > 
>  > > Original change's description:
>  > > > Correctly initialize and test SnapContainerData in cc.
>  > > > 
>  > > > This patch initializes the rect_ field in SnapContainerData in copy
>  > > > constructor and move constructor. Fixing a snapping issue in the
>  > > > composited pages.
>  > > > 
>  > > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
>  > > > test suite so that they are tested with the composited cases.
>  > > > 
>  > > > snap-at-user-scroll-end-manual-automation.js calls
>  > > > mouseClickInTarget() of pointerevent_common_input.js. That method
>  > > > invokes programmatic scrolls. The test was written before programmatic
>  > > > scroll snapping was implemented so it worked at that time. However,
>  > > > with programmatic scroll snapping implemented, it will always snap
>  > > > in mouseClickIntarget() and cannot test whether the user scroll snaps.
>  > > > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
>  > > > to avoid invoking programmatic scrolls in the test.
>  > > > 
>  > > > This patch also checks nullptr for layout_box in
>  > > > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
>  > > > 
>  > > > Bug: 862406, 862571
>  > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
>  > > > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
>  > > > Reviewed-on: https://chromium-review.googlesource.com/1132386
>  > > > Commit-Queue: Sandra Sun <[e-mail]>
>  > > > Reviewed-by: Majid Valipour <[e-mail]>
>  > > > Reviewed-by: Robert Flack <[e-mail]>
>  > > > Cr-Commit-Position: refs/heads/master@{#574781}
>  > > 
>  > > TBR=[e-mail],[e-mail],[e-mail]
>  > > 
>  > > Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
>  > > No-Presubmit: true
>  > > No-Tree-Checks: true
>  > > No-Try: true
>  > > Bug: 862406, 862571
>  > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
>  > > Reviewed-on: https://chromium-review.googlesource.com/1136171
>  > > Reviewed-by: Taiju Tsuiki <[e-mail]>
>  > > Commit-Queue: Taiju Tsuiki <[e-mail]>
>  > > Cr-Commit-Position: refs/heads/master@{#574825}
>  > 
>  > TBR=[e-mail],[e-mail],[e-mail],[e-mail]
>  > 
>  > Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3
>  > No-Presubmit: true
>  > No-Tree-Checks: true
>  > No-Try: true
>  > Bug: 862406, 862571
>  > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
>  > Reviewed-on: https://chromium-review.googlesource.com/1136671
>  > Reviewed-by: Sandra Sun <[e-mail]>
>  > Commit-Queue: Sandra Sun <[e-mail]>
>  > Cr-Commit-Position: refs/heads/master@{#574926}
>  
>  TBR=[e-mail],[e-mail],[e-mail],[e-mail]
>  
>  Change-Id: If9d1e6f73393a7dddc9f8f418606946f070b45be
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 862406, 862571
>  Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
>  Reviewed-on: https://chromium-review.googlesource.com/1136612
>  Reviewed-by: Sandra Sun <[e-mail]>
>  Commit-Queue: Sandra Sun <[e-mail]>
>  Cr-Commit-Position: refs/heads/master@{#574931}
>

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=43eb991a08390e89fb82d0d7ff8c494342257d4a

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f007063dc171
[wpt PR 11972] - Revert "Reland "Correctly initialize and test SnapContainerData in cc."", a=testonly

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f007063dc171