1475760 - Payer/contact picker dropdown labels need to take @address-fields into account

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

The dropdown labels on the address-picker currently use the usual address labels including two columns but they should take @address-fields into account to only show relevant data in the dropdowns.

Comment 1

[Matthew N. [:MattN]]

This is blocked on answers to the questions in bug 1463545 comment 4. Someone could start to implement the filtering based on @address-fields but how we handle missing values for those fields (in both the open and closed states) is what needs an answer.

Comment 2

[:prathiksha]

Attachment: Bug 1475760 - Take address-fields into account for payer/contact picker dropdown labels. r?MattN

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8998124 [details]
Bug 1475760 - Take address-fields into account for payer/contact picker dropdown labels. r?MattN

Matthew N. [:MattN] (PM if requests are blocking you) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db83318361c5
Take address-fields into account for payer/contact picker dropdown labels. r=MattN

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/db83318361c5

Comment 6

[Hani Yacoub, Desktop QA]

Build ID: 20180821100053
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Verified as fixed on Firefox Nightly 63.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 17.04 x64.