Closed Bug 1475815 Opened 6 years ago Closed 6 years ago

Port bug 1475509 to TB: Stop setting custom text selection styles on dark/light themes

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr60 fixed, thunderbird62 fixed, thunderbird63 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 63.0
Tracking Flags:
Tracking Status
thunderbird_esr60 --- fixed
thunderbird62 --- fixed
thunderbird63 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

no-selection-color.patch
3.82 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
no-selection-color-ESR60.patch
4.02 KB, patch
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review 
FX removed this because it doesn't fit with the dark theme on macOS 10.14.
Port of https://hg.mozilla.org/mozilla-central/rev/b3b2ac62bbe0
We have some more lines for the compose window.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8992173 - Flags: review?(jorgk)
Comment on attachment 8992173 [details] [diff] [review]
no-selection-color.patch

Thanks. This appears to change the selection colour from blue to "light" in the search boxes and all the fields in the compose window when using the dark theme. That certainly looks better.
Attachment #8992173 - Flags: review?(jorgk) → review+
BTW, I see no difference using the "light" theme.
This is the patch for ESR60.

Yes on Win10 the colours are almost the same on Light theme.
Attachment #8992177 - Flags: approval-comm-esr60?
Comment on attachment 8992177 [details] [diff] [review]
no-selection-color-ESR60.patch

OK, but then it needs to go to beta, too. Are M-C uplifting their bug?
Attachment #8992177 - Flags: approval-comm-esr60?
Attachment #8992177 - Flags: approval-comm-esr60+
Attachment #8992177 - Flags: approval-comm-beta+
They don't have it in ESR, Maybe they uplift it to 62 because macOS 10.14 will be released during 62. We then have ESR60 and then it should be removed too.
Well, in the Gloda text box, when using a dark theme, the selection colour is blue now in TB 60 ESR, so that's bad. So why wait if we can fix it before release? BTW, with the dark theme in TB 60 ESR, Gloda and QFB text boxes look differently. Gloda is dark and QFB light. That's a bug, no? Do you want a screenshot?
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0bfa777345f9
Port bug 1475509 to TB: Stop setting custom text selection styles on dark/light themes. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
I see it too on ESR60. I'll fix it and file a bug.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: