Closed Bug 1475840 Opened 6 years ago Closed 6 years ago

Perma-fail TV tier2 browser/base/content/test/performance/browser_preferences_usage.js | Should have checked all whitelist items. Remaining: browser.startup.record - Got 1, expected 0

Categories

(Firefox :: General, defect, P5)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: johannh)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell needswork:owner])

Attachments

(1 file)

Bug 1475840 - Don't fail browser_preferences_usage.js because browser.startup.record is only accessed on startup. r=florian
46 bytes, text/x-phabricator-request
florian
: review+
Details | Review 
Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=188229992&repo=mozilla-central

https://queue.taskcluster.net/v1/task/UqjcPC0hSVmFzElbOscYaA/runs/0/artifacts/public/logs/live_backing.log

11:53:57     INFO -  100 INFO TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item dom.ipc.processCount should be accessed at most 15 times. - 10 <= 15 -
11:53:57     INFO -  101 INFO TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.tabs.insertAfterCurrent should not be accessed more than 15 times. - 10 <= 15 -
11:53:57     INFO -  102 INFO TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item layout.css.dpi should be accessed at most 35 times. - 6 <= 35 -
11:53:57     INFO -  103 INFO TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | dom.ipc.keepProcessesAlive.web should not be accessed more than 15 times. - 3 <= 15 -
11:53:57     INFO -  104 INFO TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.schedulePressure.defaultCount should not be accessed more than 15 times. - 2 <= 15 -
11:53:57     INFO -  105 INFO TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.privatebrowsing.autostart should not be accessed more than 15 times. - 1 <= 15 -
11:53:57     INFO -  Buffered messages finished
11:53:57    ERROR -  106 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | Should have checked all whitelist items. Remaining: browser.startup.record - Got 1, expected 0
11:53:57     INFO -  Stack trace:
11:53:57     INFO -  chrome://mochikit/content/browser-test.js:test_is:1305
11:53:57     INFO -  chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:checkPrefGetters:54
11:53:57     INFO -  chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:open_10_tabs:167
11:53:57     INFO -  chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
11:53:57     INFO -  chrome://mochikit/content/browser-test.js:Tester_execTest:1094
11:53:57     INFO -  chrome://mochikit/content/browser-test.js:nextTest/<:991
11:53:57     INFO -  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
11:53:57     INFO -  107 INFO Leaving test bound open_10_tabs
11:53:57     INFO -  108 INFO Entering test bound navigate_around
11:53:57     INFO -  GECKO(6988) | ++DOCSHELL 000001DDA7784800 == 5 [pid = 7760] [id = {0ea23e63-2563-4f95-9985-2df0a551881c}]
11:53:57     INFO -  GECKO(6988) | ++DOMWINDOW == 66 (000001DDA833CE00) [pid = 7760] [serial = 73] [outer = 0000000000000000]
11:53:57     INFO -  GECKO(6988) | Waiting for browser load
11:53:57     INFO -  GECKO(6988) | ++DOMWINDOW == 67 (000001DDA83EB000) [pid = 7760] [serial = 74] [outer = 000001DDA833CE00]
11:53:57     INFO -  GECKO(6988) | Saw state f0001 and status 0
11:53:57     INFO -  GECKO(6988) | ++DOMWINDOW == 68 (000001DD9FF78800) [pid = 7760] [serial = 75] [outer = 000001DDA833CE00]
11:53:57     INFO -  GECKO(6988) | Saw state c0010 and status 0
11:53:57     INFO -  GECKO(6988) | Browser loaded http://example.com/
Summary: Intermittent browser/base/content/test/performance/browser_preferences_usage.js | Should have checked all whitelist items. Remaining: browser.startup.record - Got 1, expected 0 → Perma-fail tier2 browser/base/content/test/performance/browser_preferences_usage.js | Should have checked all whitelist items. Remaining: browser.startup.record - Got 1, expected 0
This is TV failure and according to Intermittent Failures view, the last fail was 2 days ago: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2e309ddea982b4275a1da7523eb13e27ab7f15b4&selectedJob=188221446&filter-searchStr=Linux%20x64%20debug%20test-linux64%2Fdebug-test-verify-e10s%20(TV)
Summary: Perma-fail tier2 browser/base/content/test/performance/browser_preferences_usage.js | Should have checked all whitelist items. Remaining: browser.startup.record - Got 1, expected 0 → Perma-fail TV tier2 browser/base/content/test/performance/browser_preferences_usage.js | Should have checked all whitelist items. Remaining: browser.startup.record - Got 1, expected 0
Florian, do you have an idea why this pref stopped showing up in the test on TV only?
Flags: needinfo?(florian)
This failure is happening only on debug builds. Does this give us a hint about what may have changed?
No, the test only runs on debug builds since recording the pref data is a memory overhead :)

Kris changed a bunch of stuff around prefs recently, maybe he knows?
There have been 35 failures in the last 7 days, on Debug:
- 7 failures on Linux x64 
- 8 failures on OS X 10.10 
- 7 failures on Windows 10x64 
- 3 failures on windows10-64-msvc 
- 7 failures on Windows 7
- 3 failures on windows7-32-msvc

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190928471&repo=autoland&lineNumber=47154

17:49:23     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.privatebrowsing.autostart should not be accessed more than 15 times. - 1 <= 15 - 
17:49:23     INFO - Buffered messages finished
17:49:23     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | Should have checked all whitelist items. Remaining: browser.startup.record - Got 1, expected 0
17:49:23     INFO - Stack trace:
17:49:23     INFO - chrome://mochikit/content/browser-test.js:test_is:1305
17:49:23     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:checkPrefGetters:54
17:49:23     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:open_10_tabs:167
17:49:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
17:49:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
17:49:23     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:991
17:49:23     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
17:49:23     INFO - Leaving test bound open_10_tabs
17:49:23     INFO - Entering test bound navigate_around
Flags: needinfo?(dolske)
Whiteboard: [stockwell needswork:owner]
There's no reason to run this test in verify mode.
Tier 2 and low rate isn't a priority anyway.
Flags: needinfo?(dolske)
(In reply to Johann Hofmann [:johannh] from comment #3)
> Florian, do you have an idea why this pref stopped showing up in the test on
> TV only?

I still have no idea about why the TV behavior changed, but this pref is only accessed the first time we load a JS module or JS XPCOM component, so it makes sense that we don't access it when TV runs the same test code several times in a row.
Flags: needinfo?(florian)
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Comment on attachment 9004193 [details]
Bug 1475840 - Don't fail browser_preferences_usage.js because browser.startup.record is only accessed on startup. r=florian

Florian Quèze [:florian] has approved the revision.
Attachment #9004193 - Flags: review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e42a6a201f0
Don't fail browser_preferences_usage.js because browser.startup.record is only accessed on startup. r=florian
https://hg.mozilla.org/mozilla-central/rev/4e42a6a201f0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: