1475916 - Only 4 rows are displayed in the profile manager

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alice0775 White]

Attachment: screensot, 63.0a1 vs 62.0b8

[Tracking Requested - why for this release]: Regression of usability

Steps To Reproduce:
1. Start Firefox.exe -p

Actual Results:
only 4 rows.
It is slightly difficult to choice a profile because too few rows are displayed at a time.

Expected Results:
At least, 5 rows like previous version


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a34a6f54da753e87e778e477f2760753ebf519b6&tochange=bd281782dc93474944f6a9375312e7e3a31cd061

Regressed by: 0b45728b7210	Paolo Amadini — Bug 1472750 - Convert simple "listbox" instances to "richlistbox". r=bgrins

Comment 1

[Pascal Chevrel:pascalc]

Paolo, it seems that your patch in Bug 1472750 caused this regression, could you have a look please? Thanks

Comment 2

[:Paolo Amadini]

Attachment: Bug 1475916 - Use em instead of px for list heights to keep font scaling into account.

Review commit: https://reviewboard.mozilla.org/r/258342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258342/

Comment 3

[:Paolo Amadini]

I'm not too concerned about the exact height of this list, but it makes sense to set the height using em to keep into account desktop font scaling. I've also given the list a few more rows on average.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to :Paolo Amadini from comment #3)
> I'm not too concerned about the exact height of this list, but it makes
> sense to set the height using em to keep into account desktop font scaling.
> I've also given the list a few more rows on average.

There will be a similar issue for any listbox that got converted richlistbox and set [height] in the markup, right? Or is there something different about ones that have theme-listbox applied?

Comment 5

[:Paolo Amadini]

(In reply to Brian Grinstead [:bgrins] from comment #4)
> There will be a similar issue for any listbox that got converted richlistbox
> and set [height] in the markup, right?

Right, it looks like the one in "languages.xul" can also be converted to use "em".

Comment 6

[:Paolo Amadini]

Comment on attachment 8993654 [details]
Bug 1475916 - Use em instead of px for list heights to keep font scaling into account.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258342/diff/1-2/

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8993654 [details]
Bug 1475916 - Use em instead of px for list heights to keep font scaling into account.

https://reviewboard.mozilla.org/r/258342/#review265698

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ada757eb3b82
Use em instead of px for list heights to keep font scaling into account. r=bgrins

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ada757eb3b82