1475947 - Font editor: font-size unit conversion for vw/vh is broken

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Razvan Caliman [:rcaliman]]

Steps:

- Go to https://v-fonts.com/
- Inspect the first font preview in DevTools
- Switch to the Fonts panel
- Change the font-size dropdown from `px` (or `em`) to `vh` or `vw`

Expected:
- The font-size is converted to the viewport unit and scaled proportionally

Result
- The unit value is changed, but the number stays the same. The value is not reflected on the page.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1475947 - (Part 1) implement getOwnerGlobalDimensions() on Node actor.

Review commit: https://reviewboard.mozilla.org/r/257452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257452/

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1475947 - (Part 2) Update font editor unit conversion to use getOwnerGlobalDimensions().

Review commit: https://reviewboard.mozilla.org/r/257454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257454/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8992587 [details]
Bug 1475947 - (Part 1) implement getOwnerGlobalDimensions() on Node actor.

https://reviewboard.mozilla.org/r/257452/#review264422

::: devtools/shared/specs/node.js:128
(Diff revision 1)
>          value: RetVal("string")
>        }
>      },
> +    getOwnerGlobalDimensions: {
> +      request: {},
> +      response: RetVal("json")

Since the object { innerWidth, innerHeight } we're returning is a pretty simple object, we should try to define a new RetVal type instead of using "json".

You can find an example here.
https://searchfox.org/mozilla-central/source/devtools/shared/specs/node.js#13-18

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8992588 [details]
Bug 1475947 - (Part 2) Update font editor unit conversion to use getOwnerGlobalDimensions().

https://reviewboard.mozilla.org/r/257454/#review264424

Comment 5

[Razvan Caliman [:rcaliman]]

Comment on attachment 8992587 [details]
Bug 1475947 - (Part 1) implement getOwnerGlobalDimensions() on Node actor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257452/diff/1-2/

Comment 6

[Razvan Caliman [:rcaliman]]

Comment on attachment 8992588 [details]
Bug 1475947 - (Part 2) Update font editor unit conversion to use getOwnerGlobalDimensions().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257454/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0faca4ace71
(Part 1) implement getOwnerGlobalDimensions() on Node actor. r=gl
https://hg.mozilla.org/integration/autoland/rev/4c28d3e3db9d
(Part 2) Update font editor unit conversion to use getOwnerGlobalDimensions(). r=gl

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b0faca4ace71
https://hg.mozilla.org/mozilla-central/rev/4c28d3e3db9d

Comment 9

[Catalin Sasca, Desktop QA [:csasca]]

I successfully reproduced the issue on Firefox Nightly 63.0a1 (2018-07-16) under Windows 10 (x64) using the STR from Comment 0.

The issue is no longer reproducible on Firefox Beta 63.0b13 and latest Firefox 64.0a1 (2018-10-09). Tests were performed on Windows 10 (x64), macOS 10.13 and Ubuntu 16.04 (x64).