Closed Bug 1475964 Opened 5 years ago Closed 5 years ago

[Static Analysis] Errors in accessible/atk/

Categories

(Core :: Disability Access APIs, defect, P3)

Product:
Core
Component:
Disability Access APIs
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: rbartlensky, Assigned: rbartlensky)

References

Details

Attachments

(1 file)

Bug 1475964: Add null checks in nsMaiInterfaceTableCell.cpp.
59 bytes, text/x-review-board-request
davidb
: review+
Details 
accessible/atk/nsMaiInterfaceTableCell.cpp:58: error: NULL_DEREFERENCE
  pointer `cell` last assigned on line 57 could be null and is dereferenced at line 58, column 13.
  56.     if (AccessibleWrap* accWrap = GetAccessibleWrap(ATK_OBJECT(aCell))) {
  57.       TableCellAccessible* cell = accWrap->AsTableCell();
  58. >     *aRow = cell->RowIdx();
  59.       *aCol = cell->ColIdx();
  60.       return true;

accessible/atk/nsMaiInterfaceTableCell.cpp:79: error: NULL_DEREFERENCE
  pointer `cellAcc` last assigned on line 78 could be null and is dereferenced at line 79, column 13.
  77.     if (AccessibleWrap* accWrap = GetAccessibleWrap(ATK_OBJECT(aCell))) {
  78.       TableCellAccessible* cellAcc = accWrap->AsTableCell();
  79. >     *aCol = cellAcc->ColIdx();
  80.       *aRow = cellAcc->RowIdx();
  81.       *aColExtent = cellAcc->ColExtent();

accessible/atk/nsMaiInterfaceDocument.cpp:88: error: NULL_DEREFERENCE
  pointer `document` last assigned on line 87 could be null and is dereferenced at line 88, column 5.
  86.
  87.       DocAccessible* document = accWrap->AsDoc();
  88. >     document->URL(url);
  89.       document->DocType(w3cDocType);
  90.       document->MimeType(mimeType);
Blocks: infer
Last issue is a False Positive.
Comment on attachment 8992338 [details]
Bug 1475964: Add null checks in nsMaiInterfaceTableCell.cpp.

https://reviewboard.mozilla.org/r/257208/#review265242
Attachment #8992338 - Flags: review?(dbolter) → review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3cfdf00c7f2
Add null checks in nsMaiInterfaceTableCell.cpp. r=davidb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b3cfdf00c7f2
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.