1475998 - Add a clang x86 build

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

(I'll worry about this after x64 is landed.)

Comment 1

[Ahmer]

I found a bug in Waterfox.I want to ask,You pay bug bounty for water fox browser bug?

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 9010307 [details]
Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj

Nathan Froyd [:froydnj] has approved the revision.

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj

This commit also removes dwarf-exceptions from the x64 build.
sjlj exceptions are needed on x86 because there is a bug currently involving
SEH exceptions on x86.  However on x64 there is not, so we can use the
default SEH and get rid of dwarf exceptions.

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

> From your commit message, it sounds like fuse-cxa-atexit is only necessary for (native?) SEH handling. So we don't actually need this for x86, is that correct? If that's correct, should we just put fuse-cxa-atexit in WRAPPER_FLAGS for non-x86 targets only?

As I understand it (Jacek and Martin know best) we want to use -fuse-cxa-atexit period. We (Mozilla) just never got around to adding it to our build script after Martin fixed it (IIRC?).  But we do need to add it for SEH to work.  Jacek do I have this right?

Comment 7

[Jacek Caban]

-fuse-cxa-atexit is not strictly needed AFAIK. I added it in my WIP patch because Martin used it in his builds so that's a better tested config (and AFAIR that's what GCC config uses), but we may probably skip it if it's controversial.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df47d3ad9cc6
Add a x86 MinGW Clang Build Job r=froydnj

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for Windows MinGW bustages

Push link: https://hg.mozilla.org/integration/autoland/rev/df47d3ad9cc61d1462618ba18dbd2c3359bcc1e7
Backout link: https://hg.mozilla.org/integration/autoland/rev/3f74fda7be1ba60f1afe82c6b7bbaaff2b60ee96
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=204254964&repo=autoland&lineNumber=27385

Comment 10

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Found problem, fixed problem.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28530a1156ce
Add a x86 MinGW Clang Build Job r=froydnj

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/28530a1156ce

Comment 13

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/4c87d872a896