Closed Bug 1476000 Opened Last year Closed Last year

./mach build-warnings-list does not work with clang-cl builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

The build system cannot summarize warnings when clang-cl is used.
This is an example of clang-cl warnings:
 1:20.75 e:/m/mozilla-unified/widget/windows/JumpListBuilder.cpp(37,22):  warning: unused variable 'kJumpListItemCID' [-Wunused-const-variable]

The differences from genuine MSVC are:
* A column number is present after a line number.
* Multiple spaces are present before the `warning` token.
* No error code (Cxxxx) is present after `warning`.
* An error flag (-Wxxxx) is present at the end of the error message.
Maybe a better comparison would be against genuine clang. This output looks pretty similar to `RE_CLANG_WARNING`, except the line/column is written as foo.cpp(1,2) instead of foo.cpp:1:2.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8992373 - Flags: review?(dmajor)
Comment on attachment 8992373 [details] [diff] [review]
Support warnings format from clang-cl

If this works for you locally, then it seems fine to me.
Attachment #8992373 - Flags: review?(dmajor) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/896f75ea7634
Support warnings format from clang-cl. r=dmajor
https://hg.mozilla.org/mozilla-central/rev/896f75ea7634
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.