1476000 - ./mach build-warnings-list does not work with clang-cl builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masatoshi Kimura [:emk]]

The build system cannot summarize warnings when clang-cl is used.

Comment 1

[(Away)]

I _think_ we just need to add a new clang-cl regex to https://searchfox.org/mozilla-central/rev/b0275bc977ad7fda615ef34b822bba938f2b16fd/python/mozbuild/mozbuild/compilation/warnings.py#331

Comment 2

[Masatoshi Kimura [:emk]]

This is an example of clang-cl warnings:
 1:20.75 e:/m/mozilla-unified/widget/windows/JumpListBuilder.cpp(37,22):  warning: unused variable 'kJumpListItemCID' [-Wunused-const-variable]

The differences from genuine MSVC are:
* A column number is present after a line number.
* Multiple spaces are present before the `warning` token.
* No error code (Cxxxx) is present after `warning`.
* An error flag (-Wxxxx) is present at the end of the error message.

Comment 3

[(Away)]

Maybe a better comparison would be against genuine clang. This output looks pretty similar to `RE_CLANG_WARNING`, except the line/column is written as foo.cpp(1,2) instead of foo.cpp:1:2.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Support warnings format from clang-cl

Comment 5

[(Away)]

Comment on attachment 8992373 [details] [diff] [review]
Support warnings format from clang-cl

If this works for you locally, then it seems fine to me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/896f75ea7634
Support warnings format from clang-cl. r=dmajor

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/896f75ea7634