[Static Analysis] DEAD_STORE error in storage/mozStorageHelper.h

RESOLVED FIXED in Firefox 63

Status

()

defect
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: rbartlensky, Assigned: rbartlensky)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
storage/mozStorageHelper.h:157: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  155.       // TODO (bug 1062823): from Sqlite 3.7.11 on, rollback won't ever return
  156.       // a busy error, so this handling can be removed.
  157. >     nsresult rv = NS_OK;
  158.       do {
  159.         rv = mConnection->ExecuteSimpleSQL(NS_LITERAL_CSTRING("ROLLBACK"));
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8992391 [details]
Bug 1476009: Remove unnecessary initialization.

https://reviewboard.mozilla.org/r/257266/#review264340
Attachment #8992391 - Flags: review?(mak77) → review+
(Assignee)

Updated

9 months ago
Keywords: checkin-needed

Comment 3

9 months ago
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44fd25e3d484
Remove unnecessary initialization. r=mak
Keywords: checkin-needed

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/44fd25e3d484
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.