[meta] about:crashes user interface update

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P1
normal
RESOLVED FIXED
10 months ago
5 months ago

People

(Reporter: alexisdeschamps, Assigned: alexisdeschamps)

Tracking

(Depends on 1 bug, Blocks 1 bug, {meta})

Trunk
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 64+, firefox63- wontfix, firefox64 fixed)

Details

Attachments

(2 attachments)

Tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1463515.

The current about:crashes user interface has a few problems that need to be fixed. The problems to fix are listed in the tracking bug.

This bug covers doing the implementation for the user interface changes. This is the mock-up for the new user interface: https://bug1463515.bmoattachments.org/attachment.cgi?id=8990380
Assignee

Updated

10 months ago
Assignee: nobody → adeschamps
Status: NEW → ASSIGNED
No longer depends on: 1469339, 1476034
Is this planned to land in 63? 
I guess it will need localization, and maybe some testing. 
It looks really nice, by the way!
Alexis, is this going to land during the 63 development cycle?
Flags: needinfo?(adeschamps)
I do believe this will land within the next two weeks, so I think that means it would land during the 63 development cycle.
Flags: needinfo?(adeschamps)
I don't think that we want to promote this change in our final release notes for end-users, but we certainly want to mention it in our Nightly release notes since we want our pre-release channel population to file bugs. Will there be a short blog post presenting the changes that we would link to from the release notes? (could be on the Nightly blog).
Flags: needinfo?(adeschamps)
Hmm, yes, I could write something. Not sure what the process is for that though. Please feel free to send me information.
Flags: needinfo?(adeschamps)
The about:crashes page's user interface is being updated (bug 1463515).

- changed crash submission to be done through button press instead of link clicking
    - this allows users to know that they are submitting the crash
- updated visuals to match new mock-up
    - mock-up image: https://bug1463515.bmoattachments.org/attachment.cgi?id=8990380
- added new Fluent strings that are needed for the new user interface
- modernized the surrounding code
Comment on attachment 8997959 [details]
about:crashes: updated user interface (bug 1476062); r=flod, pike

Francesco Lodolo [:flod] has approved the revision.

https://phabricator.services.mozilla.com/D2792
Attachment #8997959 - Flags: review+
:jsavory What are your thoughts on what the confirmation texts should be for the "Clear All" buttons?

Here is what I currently have from modifying the original text:

"Clear All" confirmation text for unsubmitted reports: "This will delete all unsubmitted crash reports and cannot be undone."
Image: https://i.imgur.com/v07u7gm.png

"Clear All" confirmation text for submitted reports: "This will remove the links to your submitted crash reports and cannot be undone. The submitted data will not be deleted."
Image: https://i.imgur.com/JECmh7D.png

Also, do you think it might be a good idea to flip the order of the unsubmitted and submitted crash reports tables? :philipp mentioned that it would help support users when trying to guide them to pick reports that start with "bp-".
Flags: needinfo?(jsavory)
I was asked to review this patch on Phabricator, but it sounds like there are a few outstanding questions to be answered (comment 8).

I also have a question - the original about:crashes listed the submitted date rather than the crashed date in the submitted crash report list. The UX spec has changed that. I just want to ensure that this was an intentional change? I don't have much skin in the game either way, but I want to make sure it was intentional and not a copy-paste error.
Flags: needinfo?(adeschamps)
(In reply to Mike Conley (:mconley) (:⚙️) from comment #9)
> I also have a question - the original about:crashes listed the submitted
> date rather than the crashed date in the submitted crash report list. The UX
> spec has changed that. I just want to ensure that this was an intentional
> change? I don't have much skin in the game either way, but I want to make
> sure it was intentional and not a copy-paste error.

I guess nevermind this last part - looking at the patch, it looks like the table header has stayed with Date Submitted for submitted crash reports.
Thank you for the great initial review :mconley! I added updates to https://phabricator.services.mozilla.com/D2792 that should address all of comments. I think that, due to my internship ending tomorrow, I may not have time to go over those questions (exact copy for "Clear All" buttons and order of the lists).
Flags: needinfo?(adeschamps)
The copy looks great Alexis, I might just reword the submitted reports one a little bit. Possibly like: "This will remove the list of submitted crash reports but will not delete the submitted data. This cannot be undone.

In terms of flipping the order, do you mean having the submitted section above the unsubmitted? I kind of assumed that people interact with the unsubmitted section more, therefore it should be at the top. That said, I'm not very familiar with how people use this screen so I am happy to flip them if the submitted section is considered more important.
Flags: needinfo?(jsavory)
(In reply to Alexis Deschamps [:alexisdeschamps] from comment #11)
> Thank you for the great initial review :mconley! I added updates to
> https://phabricator.services.mozilla.com/D2792 that should address all of
> comments. I think that, due to my internship ending tomorrow, I may not have
> time to go over those questions (exact copy for "Clear All" buttons and
> order of the lists).

Just so ya'll know I'll take over finishing up this bug once Alexis is gone.
Attachment #8997959 - Flags: review?(mconley)
Comment on attachment 8997959 [details]
about:crashes: updated user interface (bug 1476062); r=flod, pike

Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #8997959 - Flags: review+
Attachment #8997959 - Flags: review?(mconley)

Comment 15

9 months ago
Pushed by mkelly@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4b8f03094c3
about:crashes: updated user interface ; r=mconley,flod
Backed out for failures on browser_aboutCrashesResubmit.js

backout: https://hg.mozilla.org/integration/autoland/rev/a4c481a0b09bb027d3662b5d536b223fdbf47979

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e4b8f03094c3ea69d6b596c686b1c56d03fe979d&selectedJob=196739925

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196739925&repo=autoland&lineNumber=3877

12:35:03     INFO - TEST-START | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js
12:35:04     INFO - TEST-INFO | started process screencapture
12:35:04     INFO - TEST-INFO | screencapture: exit 0
12:35:04     INFO - Buffered messages logged at 12:35:04
12:35:04     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | about:crashes lists correct number of crash reports - 2 == 2 - 
12:35:04     INFO - Buffered messages finished
12:35:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | 0: crash ID is correct - "bp-9d3aac9f-763a-1e41-9c00-44b00930e64" == "ba8a0300-3c3f-b343-a528-4a1c53380c8d" - 
12:35:04     INFO - Stack trace:
12:35:04     INFO - resource://testing-common/content-task.js line 59 > eval:check_crash_list:13
12:35:04     INFO - resource://testing-common/content-task.js:null:60
12:35:04     INFO - Not taking screenshot here: see the one that was previously logged
12:35:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | 1: crash ID is correct - "ba8a0300-3c3f-b343-a528-4a1c53380c8d" == "bp-9d3aac9f-763a-1e41-9c00-44b00930e64" - 
12:35:04     INFO - Stack trace:
12:35:04     INFO - resource://testing-common/content-task.js line 59 > eval:check_crash_list:13
12:35:04     INFO - resource://testing-common/content-task.js:null:60
12:35:04     INFO - Console message: [JavaScript Error: "The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature." {file: "http://example.com/browser/toolkit/crashreporter/test/browser/crashreport.sjs?id=bp-9273e5b8-6fe6-e64e-9f8f-d2581a8be08" line: 0}]
12:35:04     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | got submission onload - 
12:35:04     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | minidump file sent properly - "MDMP" == "MDMP" - 
12:35:04     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | memory report sent properly - "Let's pretend this is a memory report" == "Let's pretend this is a memory report" - 
12:35:04     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | correctly sent as non-throttleable - 0 == 0 - 
12:35:04     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | submitted value for ProductName matches expected - 
12:35:04     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | submitted value for Foo matches expected - 
12:35:05     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | navigated back successfully - "about:crashes" == "about:crashes" - 
12:35:05     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | crash report link changed correctly - {} != null - 
12:35:05     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | crash report link points to correct href - "http://example.com/browser/toolkit/crashreporter/test/browser/crashreport.sjs?id=bp-9273e5b8-6fe6-e64e-9f8f-d2581a8be08" == "http://example.com/browser/toolkit/crashreporter/test/browser/crashreport.sjs?id=bp-9273e5b8-6fe6-e64e-9f8f-d2581a8be08" - 
12:35:05     INFO - GECKO(2313) | MEMORY STAT | vsize 4181MB | residentFast 313MB | heapAllocated 134MB
12:35:05     INFO - TEST-OK | toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js | took 2041ms
Flags: needinfo?(mkelly)
- Make crash submission explicit by triggering it via a button instead of by
  clicking on the crash ID link.
- Replace the single "Remove All Reports" button with two "Clear All" buttons,
  one for each category of crashes.
- Add a "View" button instead of making crash IDs links to make it explicit that
  you are viewing crash data and not submitting it.

Remove implicit dependence of the order of crash IDs in about:crashes test.
Flags: needinfo?(mkelly)
Comment on attachment 9005516 [details]
Bug 1476062: Update about:crashes UI.

Francesco Lodolo [:flod] has approved the revision.
Attachment #9005516 - Flags: review+
Comment on attachment 9005516 [details]
Bug 1476062: Update about:crashes UI.

Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9005516 - Flags: review+

Comment 21

9 months ago
Pushed by mkelly@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2bffd03584a
Update about:crashes UI. r=mconley,flod

Comment 22

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d2bffd03584a
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
This landed in 64, I think we can just let it ride the trains with 64. A release note for Nightly (64) would be welcome as we want to encourage our core community to file crash bugs.

Michael could you ask for a nightly release note addition when you feel this is ready? Thanks
Flags: needinfo?(mkelly)
I couldn't figure

Nightly Release Note Request
[Why is this notable]: It redesigns about:crashes, which we commonly encourage core community members to use to submit crashes and, via Socorro, file crash bugs.
[Affects Firefox for Android]: Yes
[Suggested wording]: about:crashes has been redesigned to make it clear when a crash is being submitted to Mozilla, as well as being clear that removing crashes locally does not remove them from crash-stats.mozilla.com
[Links (documentation, blog post, etc)]: I should edit https://support.mozilla.org/en-US/kb/mozillacrashreporter, but need to ask what the process is for changes that are only in Nightly currently.
relnote-firefox: --- → ?
Flags: needinfo?(mkelly)
(In reply to Michael Kelly [:mkelly,:Osmose] from comment #24)
> I couldn't figure

Well okay guess I could.
See Also: → 1490061
Blocks: 1490063
(In reply to Michael Kelly [:mkelly,:Osmose] from comment #24)
> 
> Nightly Release Note Request


Thanks, note added to https://www.mozilla.org/en-US/firefox/64.0a1/releasenotes/. I am leaving the relnote-firefox? flag for the 64 release manager to decide if this should be mentioned in 64 Beta release notes.
I just noticed this change and I wanted to say that it looks really nice! Thanks to everyone involved! This is the first major change to about:crashes in the 10 years since it first landed (bug 411490), where I bribed Mossop with a bottle of whiskey to implement it for me. :)
Added to 64beta relnotes:
about:crashes has been redesigned to make it clear when a crash is being submitted to Mozilla, as well as being clear that removing crashes locally does not remove them from crash-stats.mozilla.com
Summary: about:crashes user interface update → [meta] about:crashes user interface update
Depends on: 1513554
You need to log in before you can comment on or make changes to this bug.