1476071 - Extend Tab Spinner telemetry probes

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

I'm not certain I'm filing this in the right place, but here goes.

I have a dashboard hosted at http://mikeconley.github.io/bug1310250 that graphs tab switch spinner statistics from our Nightly population.

That graph is fed by a JSON file hosted at https://s3-us-west-2.amazonaws.com/telemetry-public-analysis-2/spinner-severity-generator/data/severities_by_build_id_nightly.json.

I believe that JSON file is updated by this "ETL" job:

https://github.com/mozilla/python_mozetl/tree/master/mozetl/tab_spinner

So, assuming all of that is true, I guess the ETL job isn't updating the JSON file anymore - at least, not the JSON file that the dashboard is reading from.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey, frank! Did I file this in the right place, and if so, any idea what's going on here?

Comment 2

[Frank Bertsch [:frank]]

Hey Mike, yes, this is fine! Thanks for reporting this. It looks like the job _is_ being run and the data _is_ being updated, but the data is all 0s, because the probe expired [0]! The fix is simple, just change the version in Histograms.json [1].

[0] https://telemetry.mozilla.org/probe-dictionary/?search=FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS&detailView=histogram%2FFX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS
[1] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#5811

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Thanks for the detective work, frank!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1476071 - Extend lifetime of tab-spinner related probes to v70. data-review=liuche,r?dthayer

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hey liuche, are we okay data-review-wise to extend these probe lifetimes?

Comment 6

[Phabricator Automation]

Comment on attachment 8992760 [details]
Bug 1476071 - Extend lifetime of tab-spinner related probes to v70. data-review=liuche,r?dthayer

Doug Thayer [:dthayer] has approved the revision.

https://phabricator.services.mozilla.com/D2198

Comment 7

[Chenxia Liu [:liuche]]

Oh man, phabricator! data-review+ from me, review form in Phabricator, but requesting adding some missing fields to a couple of the probes (bug #, alert email)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2bfc4560e97
Extend lifetime of tab-spinner related probes to v70. data-review=liuche,r=dthayer

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e2bfc4560e97