1476228 - Enforce comma-dangle eslint rule in Places

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P3)

Description

[Marco Bonardo [:mak]]

I'd like to evaluate how much complex it would be to enforce
"comma-dangle": ["error", "always-multiline"],
in toolkit/components/places and browser/components/places

Preserving immediately visible blame is imo more important than subjective code aesthetics, and being consistent across the module is also worth it.

Comment 1

[Mark Banner (:standard8)]

Shouldn't be too complex, though I wonder if we can convince browser/ & toolkit/ (or maybe all of m-c) to enable it.

Comment 2

[Mark Banner (:standard8)]

Since we're a little quieter at the moment, and Marco has already said he'd like to see this done, then I've decided to pick this up and run with it.

This is pretty much all auto-fixable, apart from a few lines in .xml files.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1476228 - Enable comma-dangle ESLint rule for Places directories.

MozReview-Commit-ID: K8HcZfyF4Sz

Comment 4

[:Paolo Amadini]

That's very welcome and it's good that it's auto-fixable. I'd also like to see this for all of "browser" and "toolkit", but if you want to start with the two respective "downloads" folder I can review a patch!

Comment 5

[Mark Banner (:standard8)]

(In reply to :Paolo Amadini from comment #4)
> That's very welcome and it's good that it's auto-fixable. I'd also like to
> see this for all of "browser" and "toolkit", but if you want to start with
> the two respective "downloads" folder I can review a patch!

Yeah, that's in the plan, I'm going to be sending out to relevant mailing lists soon.

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 9002485 [details]
Bug 1476228 - Enable comma-dangle ESLint rule for Places directories.

Mike de Boer [:mikedeboer] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15ee3d748ec8
Enable comma-dangle ESLint rule for Places directories. r=mikedeboer

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/15ee3d748ec8