Enforce comma-dangle eslint rule in Places

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: mak, Assigned: standard8)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

10 months ago
I'd like to evaluate how much complex it would be to enforce
"comma-dangle": ["error", "always-multiline"],
in toolkit/components/places and browser/components/places

Preserving immediately visible blame is imo more important than subjective code aesthetics, and being consistent across the module is also worth it.
Assignee

Comment 1

10 months ago
Shouldn't be too complex, though I wonder if we can convince browser/ & toolkit/ (or maybe all of m-c) to enable it.
Assignee

Comment 2

9 months ago
Since we're a little quieter at the moment, and Marco has already said he'd like to see this done, then I've decided to pick this up and run with it.

This is pretty much all auto-fixable, apart from a few lines in .xml files.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Assignee

Comment 3

9 months ago
MozReview-Commit-ID: K8HcZfyF4Sz

Comment 4

9 months ago
That's very welcome and it's good that it's auto-fixable. I'd also like to see this for all of "browser" and "toolkit", but if you want to start with the two respective "downloads" folder I can review a patch!
Assignee

Comment 5

9 months ago
(In reply to :Paolo Amadini from comment #4)
> That's very welcome and it's good that it's auto-fixable. I'd also like to
> see this for all of "browser" and "toolkit", but if you want to start with
> the two respective "downloads" folder I can review a patch!

Yeah, that's in the plan, I'm going to be sending out to relevant mailing lists soon.
Comment on attachment 9002485 [details]
Bug 1476228 - Enable comma-dangle ESLint rule for Places directories.

Mike de Boer [:mikedeboer] has approved the revision.
Attachment #9002485 - Flags: review+

Comment 7

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15ee3d748ec8
Enable comma-dangle ESLint rule for Places directories. r=mikedeboer

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/15ee3d748ec8
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.