Closed Bug 1476334 Opened Last year Closed Last year

Update HarfBuzz to 1.8.7

Categories

(Core :: Graphics: Text, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Overview of changes leading to 1.8.4
Tuesday, July 17, 2018
====================================
- Fix build on non-C++11.
- Use C++-style GCC atomics and C++11 atomics.

Not sure if there's much urgency to take this update, but at least we've got a bug filed for it now.
https://cgit.freedesktop.org/harfbuzz/commit/?id=44d1fb37efa20852cc466c0f0bba95dbd24ce288

Overview of changes leading to 1.8.5
Wednesday, August 1, 2018
====================================
- Major Khmer shaper improvements to better match Microsoft.
- Indic bug fixes.
- Internal improvements to atomic operations.
Summary: Update HarfBuzz to 1.8.4 → Update HarfBuzz to 1.8.5
Overview of changes leading to 1.8.6
Tuesday, August 7, 2018
====================================
- Internal code shuffling.
- New API to speed up getting advance widths for implementations
  that have heavy overhead in get_h_advance callback:
+hb_font_funcs_set_glyph_h_advances_func
+hb_font_funcs_set_glyph_v_advances_func
+hb_font_get_glyph_advances_for_direction
+hb_font_get_glyph_h_advances
+hb_font_get_glyph_h_advances_func_t
+hb_font_get_glyph_v_advances
+hb_font_get_glyph_v_advances_func_t
Summary: Update HarfBuzz to 1.8.5 → Update HarfBuzz to 1.8.6
I had a green Try run with 1.8.5 yesterday, but 1.8.6 appears to have a new reftest hang:
https://treeherder.mozilla.org/logviewer.html#?job_id=192590549&repo=try
Flags: needinfo?(jfkthame)
The 1.8.5 update sounds valuable from a bug fix / language support perspective.
Ugh... looks like the reftest failure also starts with a similar assertion, actually:
https://treeherder.mozilla.org/logviewer.html#?job_id=192590549&repo=try&lineNumber=29902

Behdad, does this look like an internal harfbuzz issue, or like we're just using it wrong? (Although it didn't complain until now!)
Flags: needinfo?(jfkthame) → needinfo?(mozilla)
Yeah, it is indeed debug-only. The opt runs are all green.
Oops.  My bug.  Fixed:
https://github.com/harfbuzz/harfbuzz/commit/883957688cc4aa4335e5131a60b3ac3b53290726

I'll get a release out.
Flags: needinfo?(mozilla)
1.8.7 is out.
1.8.6 rolled out on arch linux and makes Nightly crash when loading many pages, like https://xxx.onelogin.com/login

Crashreport: https://crash-stats.mozilla.com/report/index/3be1fb4a-57a8-41f0-ab56-3cdb60180809
looks like I should upgrade to 1.8.7 :D
I pushed a try run with 1.8.7 to confirm that it no longer asserts after the upstream fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1a27fbf1ab3e7048a1fc10d49cc8c466c162fc4
Overview of changes leading to 1.8.7
Wednesday, August 8, 2018
====================================
- Fix assertion failure with GDEF-blacklisted fonts.
Summary: Update HarfBuzz to 1.8.6 → Update HarfBuzz to 1.8.7
Your Try run looks good.
Attachment #8998829 - Flags: review?(jfkthame)
Comment on attachment 8998829 [details] [diff] [review]
Update HarfBuzz to version 1.8.7

Yeah, looks better -- let's go for it.
Attachment #8998829 - Flags: review?(jfkthame) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0cdb1cc6d65
Update HarfBuzz to version 1.8.7. r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/b0cdb1cc6d65
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Does Firefox use hb_icu_get_unicode_funcs()?  If yes, please update to 1.8.8, as that contained a crasher on ARM introduced in 1.8.4.
The only appearance in our codebase appears to be in HarfBuzz itself, so I think we're safe.
Blocks: 1483310
Right; we provide our own unicode_funcs, and don't use (or even build) the hb_icu support.
You need to log in before you can comment on or make changes to this bug.