Closed Bug 1476364 Opened Last year Closed 10 months ago

GV API to get cookies for specific (download) URL

Categories

(GeckoView :: General, enhancement, P1)

All
Android
enhancement

Tracking

(geckoview64 wontfix, geckoview65 affected, geckoview66 affected, firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 wontfix, firefox67 wontfix)

RESOLVED WONTFIX
Tracking Status
geckoview64 --- wontfix
geckoview65 --- affected
geckoview66 --- affected
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix

People

(Reporter: sebastian, Unassigned)

References

Details

(Whiteboard: [geckoview:fenix:p1] [geckoview:fenix:m2])

Focus issue: https://github.com/mozilla-mobile/focus-android/issues/2910

Focus passes downloads to Android's download manager. The download manager accepts an optional cookie parameter for downloads that may require the cookies. In the WebView version we can just ask the CookieManager:

> CookieManager.getInstance().getCookie(download.getUrl());

In GeckoView we could:

* Either add a similar API (CookieManager...getCookie(url))
* Add the cookie for the download to the ContentDelegate.onExternalResponse() callback
* Let the app store cookies on its own via some other mechanism and then the app can do the lookup.
* Other options?
Whiteboard: [geckoview:klar]
The Focus team prioritized their download manager cookie problem to P3, so this GV bug can also be P3 and doesn't need to block Focus 7.0.

https://github.com/mozilla-mobile/focus-android/issues/2910
Priority: -- → P3
Whiteboard: [geckoview:klar] → [geckoview:klar:p3]
Product: Firefox for Android → GeckoView
Summary: Get cookie(s) for specific (download) URL → GV API to get cookies for specific (download) URL
Whiteboard: [geckoview:klar:p3] → [geckoview:fenix:p1]
See Also: → 1522705

TBD whether Fenix will want this cookie API or streaming download API bug 1522705. IIUC, snorp strongly prefers the streaming download API so we're using Gecko's networking stack and certificate store.

https://github.com/mozilla-mobile/fenix/issues/214#issuecomment-461072064

Priority: P3 → P1
Whiteboard: [geckoview:fenix:p1] → [geckoview:fenix:p1] [geckoview:fenix:m2]

WONTFIX because Sebastian says that Fenix won't need this cookie API. Fenix MVP will integrate with the Android download manager, but without user cookies. After MVP, Fenix can use the streaming download API (bug 1522705) to create its own download manager.

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → WONTFIX
See Also: → 1544955
You need to log in before you can comment on or make changes to this bug.