Closed Bug 1476408 Opened Last year Closed Last year

Crash in av1_jnt_convolve_2d_avx2

Categories

(Core :: Audio/Video: Playback, defect, P3, critical)

x86_64
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed

People

(Reporter: TD-Linux, Assigned: dminor)

References

()

Details

(Keywords: crash)

Crash Data

Attachments

(3 files)

This bug was filed from the Socorro interface and is
report bp-bb8cce6f-9dd0-45ba-9922-c22370180717.
=============================================================

Top 4 frames of crashing thread:

0 XUL av1_jnt_convolve_2d_avx2 third_party/aom/aom_dsp/x86/convolve_avx2.h
1 XUL av1_convolve_2d_facade third_party/aom/av1/common/convolve.c:533
2 XUL av1_make_inter_predictor third_party/aom/av1/common/reconinter.h
3 XUL av1_make_masked_inter_predictor third_party/aom/av1/common/reconinter.c:643

=============================================================

This crash can be reproduced by playing the linked AV1 file. This crash only occurs on Mac. It may be alignment related, and may be fixed by bumping the libaom version.
Dan, I think you're dealing with those uplifts ?
Flags: needinfo?(dminor)
Priority: -- → P3
I wasn't able to get this to reproduce for me with a current nightly, but if it is alignment related, I may just have not hit the right conditions to trigger the crash when I was testing. Thomas, does this still reproduce for you?

I've already prepared an update to head of libaom. I think it might be worth updating regardless, as there have been some build system changes upstream and it would be nice to land the changes now rather than let them accumulate.
Flags: needinfo?(dminor) → needinfo?(tdaede)
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Upstream can now code generate the rtcd interface files directly from the
aom_config.h header, so we no longer have to generate an intermediate file by
running lint_config.sh. This also means we can remove the code for creating a
temporary directory.
I didn't have time to get this upstreamed prior to this update.
Thomas, I'd like to ask you for review on the update itself, but you don't have a phabricator account. Do you mind creating one and doing the review? I realize it is a bit of a rubber stamp, but you're probably the best person to catch a problem with av1 options, etc. Thanks!
Comment on attachment 8994850 [details]
Bug 1476408 - No longer necessary to run lint_config.sh anymore; r=chmanchester

Thomas Daede [:TD-Linux] has approved the revision.

https://phabricator.services.mozilla.com/D2357
Attachment #8994850 - Flags: review+
Comment on attachment 8994851 [details]
Bug 1476408 - Update libaom to rev b25610052a1398032320008d69b51d2da94f5928; r=TD-Linux

Thomas Daede [:TD-Linux] has approved the revision.

https://phabricator.services.mozilla.com/D2358
Attachment #8994851 - Flags: review+
Accidentally reviewed two patches...
Flags: needinfo?(tdaede)
Comment on attachment 8994852 [details]
Bug 1476408 - Only build stats code if examples are enabled; r=chmanchester

Thomas Daede [:TD-Linux] has approved the revision.

https://phabricator.services.mozilla.com/D2359
Attachment #8994852 - Flags: review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6054e26e2f98
No longer necessary to run lint_config.sh anymore; r=TD-Linux
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c9776cc9cb5
Update libaom to rev b25610052a1398032320008d69b51d2da94f5928; r=TD-Linux
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebcb402d09bb
Only build stats code if examples are enabled; r=TD-Linux
You need to log in before you can comment on or make changes to this bug.