1476408 - Crash in av1_jnt_convolve_2d_avx2

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Thomas Daede [:TD-Linux]]

This bug was filed from the Socorro interface and is
report bp-bb8cce6f-9dd0-45ba-9922-c22370180717.
=============================================================

Top 4 frames of crashing thread:

0 XUL av1_jnt_convolve_2d_avx2 third_party/aom/aom_dsp/x86/convolve_avx2.h
1 XUL av1_convolve_2d_facade third_party/aom/av1/common/convolve.c:533
2 XUL av1_make_inter_predictor third_party/aom/av1/common/reconinter.h
3 XUL av1_make_masked_inter_predictor third_party/aom/av1/common/reconinter.c:643

=============================================================

This crash can be reproduced by playing the linked AV1 file. This crash only occurs on Mac. It may be alignment related, and may be fixed by bumping the libaom version.

Comment 1

[Paul Adenot (:padenot)]

Dan, I think you're dealing with those uplifts ?

Comment 2

[Dan Minor [:dminor]]

I wasn't able to get this to reproduce for me with a current nightly, but if it is alignment related, I may just have not hit the right conditions to trigger the crash when I was testing. Thomas, does this still reproduce for you?

I've already prepared an update to head of libaom. I think it might be worth updating regardless, as there have been some build system changes upstream and it would be nice to land the changes now rather than let them accumulate.

Comment 3

[Dan Minor [:dminor]]

Try run for update: https://treeherder.mozilla.org/#/jobs?repo=try&revision=798be8d5a7ec8da382016c7d2d7b0d53ff0a6cf1

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1476408 - No longer necessary to run lint_config.sh anymore; r=chmanchester

Upstream can now code generate the rtcd interface files directly from the
aom_config.h header, so we no longer have to generate an intermediate file by
running lint_config.sh. This also means we can remove the code for creating a
temporary directory.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1476408 - Update libaom to rev b25610052a1398032320008d69b51d2da94f5928; r=TD-Linux

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1476408 - Only build stats code if examples are enabled; r=chmanchester

I didn't have time to get this upstreamed prior to this update.

Comment 7

[Dan Minor [:dminor]]

Thomas, I'd like to ask you for review on the update itself, but you don't have a phabricator account. Do you mind creating one and doing the review? I realize it is a bit of a rubber stamp, but you're probably the best person to catch a problem with av1 options, etc. Thanks!

Comment 8

[Phabricator Automation]

Comment on attachment 8994850 [details]
Bug 1476408 - No longer necessary to run lint_config.sh anymore; r=chmanchester

Thomas Daede [:TD-Linux] has approved the revision.

https://phabricator.services.mozilla.com/D2357

Comment 9

[Phabricator Automation]

Comment on attachment 8994851 [details]
Bug 1476408 - Update libaom to rev b25610052a1398032320008d69b51d2da94f5928; r=TD-Linux

Thomas Daede [:TD-Linux] has approved the revision.

https://phabricator.services.mozilla.com/D2358

Comment 10

[Thomas Daede [:TD-Linux]]

Accidentally reviewed two patches...

Comment 11

[Phabricator Automation]

Comment on attachment 8994852 [details]
Bug 1476408 - Only build stats code if examples are enabled; r=chmanchester

Thomas Daede [:TD-Linux] has approved the revision.

https://phabricator.services.mozilla.com/D2359

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6054e26e2f98
No longer necessary to run lint_config.sh anymore; r=TD-Linux
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c9776cc9cb5
Update libaom to rev b25610052a1398032320008d69b51d2da94f5928; r=TD-Linux
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebcb402d09bb
Only build stats code if examples are enabled; r=TD-Linux

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6054e26e2f98
https://hg.mozilla.org/mozilla-central/rev/3c9776cc9cb5
https://hg.mozilla.org/mozilla-central/rev/ebcb402d09bb