Closed
Bug 1476426
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 12038 - [LayoutNG] Fix first-line baseline when 'overflow' is not 'visible'
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 12038 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12038 Details from upstream follow. Koji Ishii <kojii@chromium.org> wrote: > [LayoutNG] Fix first-line baseline when 'overflow' is not 'visible' > > This patch fixes first-line baseline when the 'overflow' > property is other than 'visible'. > > CSS2 states that: > The baseline of an 'inline-block' is the baseline of its > last line box in the normal flow, unless it has either no > in-flow line boxes or if its 'overflow' property has a > computed value other than 'visible', in which case the > baseline is the bottom margin edge. > https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align > > This rule should apply only to 'inline-block', but it was > incorrectly applied to first-line baseline as well. > > This patch fixes incorrect alignment in the comment lines of > Gerrit code review site. > > Bug: 636993 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I49ffd8c050f384765c61c5678a431fa74492356d > Reviewed-on: https://chromium-review.googlesource.com/1140336 > WPT-Export-Revision: 08bf05d3c7b75eb9436c828046af5db2f1e593a1
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=13e18fc5e0a54c33054bc39ccf838adaf01de97f
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e47e436a25159b471e8e0b9e3b63c6056acbefe
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ff5def1f3806cb7bc4c4964d052f5eaeefdf4d9
Assignee | ||
Comment 4•6 years ago
|
||
Ran 1 tests PASS : 1
Assignee | ||
Comment 5•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=318be2d23ceba7648edc1b3e0dd75e2e072463d8
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/4773539544e7 [wpt PR 12038] - [LayoutNG] Fix first-line baseline when 'overflow' is not 'visible', a=testonly
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4773539544e7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•