Closed Bug 1476426 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12038 - [LayoutNG] Fix first-line baseline when 'overflow' is not 'visible'

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12038 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12038
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:
>  [LayoutNG] Fix first-line baseline when 'overflow' is not 'visible'
>  
>  This patch fixes first-line baseline when the 'overflow'
>  property is other than 'visible'.
>  
>  CSS2 states that:
>    The baseline of an 'inline-block' is the baseline of its
>    last line box in the normal flow, unless it has either no
>    in-flow line boxes or if its 'overflow' property has a
>    computed value other than 'visible', in which case the
>    baseline is the bottom margin edge.
>  https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align
>  
>  This rule should apply only to 'inline-block', but it was
>  incorrectly applied to first-line baseline as well.
>  
>  This patch fixes incorrect alignment in the comment lines of
>  Gerrit code review site.
>  
>  Bug: 636993
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: I49ffd8c050f384765c61c5678a431fa74492356d
>  Reviewed-on: https://chromium-review.googlesource.com/1140336
>  WPT-Export-Revision: 08bf05d3c7b75eb9436c828046af5db2f1e593a1
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4773539544e7
[wpt PR 12038] - [LayoutNG] Fix first-line baseline when 'overflow' is not 'visible', a=testonly
https://hg.mozilla.org/mozilla-central/rev/4773539544e7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.