Closed Bug 1476450 Opened 6 years ago Closed 6 years ago

Disallow text-transform in sass-lint?

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Iteration:
63.3 - Aug 6
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: k88hudson, Assigned: rrosario)

References

Details

(Whiteboard: [chore])

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4273
52 bytes, text/x-github-pull-request
Details | Review 
Based on :flod's comments in https://bugzilla.mozilla.org/show_bug.cgi?id=1475921, it seems like using text-transform is a bad idea in general. Should we perhaps disallow it via sass-lint, i.e.:

  no-disallowed-properties: [1, {properties: "text-transform"}]
Depends on: 1475921
Iteration: --- → 63.4 - Aug 20
Whiteboard: [chore]
Assignee: nobody → rrosario
Iteration: 63.4 - Aug 20 → 63.3 - Aug 6
Severity: normal → enhancement
Priority: -- → P1
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5d84ff3090c8ec68edd34b17496eae8d623a3e2d
Fix Bug 1476450 - disallow text-transform in sass-lint

https://github.com/mozilla/activity-stream/commit/e62444e6a2eccc08b7f99cf296b95483d2b3deb5
Merge pull request #4273 from rlr/bug1476450/lint-texttransform

Fix Bug 1476450 - disallow text-transform in sass-lint
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1481559
https://hg.mozilla.org/mozilla-central/rev/f0da6152e262
Blocks: 1479836
No longer blocks: 1481559
status-firefox63: --- → fixed
Target Milestone: --- → Firefox 63
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: