Closed
Bug 1476450
Opened 8 years ago
Closed 8 years ago
Disallow text-transform in sass-lint?
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: k88hudson, Assigned: rrosario)
References
Details
(Whiteboard: [chore])
Attachments
(1 external file)
Based on :flod's comments in https://bugzilla.mozilla.org/show_bug.cgi?id=1475921, it seems like using text-transform is a bad idea in general. Should we perhaps disallow it via sass-lint, i.e.:
no-disallowed-properties: [1, {properties: "text-transform"}]
Updated•8 years ago
|
Iteration: --- → 63.4 - Aug 20
Whiteboard: [chore]
| Assignee | ||
Updated•8 years ago
|
Assignee: nobody → rrosario
| Assignee | ||
Updated•8 years ago
|
Iteration: 63.4 - Aug 20 → 63.3 - Aug 6
| Reporter | ||
Updated•8 years ago
|
Severity: normal → enhancement
Priority: -- → P1
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/5d84ff3090c8ec68edd34b17496eae8d623a3e2d
Fix Bug 1476450 - disallow text-transform in sass-lint
https://github.com/mozilla/activity-stream/commit/e62444e6a2eccc08b7f99cf296b95483d2b3deb5
Merge pull request #4273 from rlr/bug1476450/lint-texttransform
Fix Bug 1476450 - disallow text-transform in sass-lint
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 3•8 years ago
|
||
status-firefox63:
--- → fixed
Target Milestone: --- → Firefox 63
Updated•7 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•