Closed
Bug 1476485
Opened 6 years ago
Closed 6 years ago
Remove pragma pack in nsUnicodeScriptCodes.h
Categories
(Core :: Internationalization, enhancement)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
It was introduced from bug 763703, but since then majority of fields have been removed since the switch to ICU, and I don't think we need it anymore. This also causes some clang-cl warnings about pack size being affected by #include.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8992828 [details] Bug 1476485 - Remove pragma pack from nsUnicodeScriptCodes.h. https://reviewboard.mozilla.org/r/257666/#review264620 Yes, looks like this should be fine.
Attachment #8992828 -
Flags: review?(jfkthame) → review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a34e2e1ed6f Remove pragma pack from nsUnicodeScriptCodes.h. r=jfkthame
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8a34e2e1ed6f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•