Closed Bug 1476486 Opened 2 years ago Closed 2 years ago

Apply the same warning suppression as clang to clang-cl

Categories

(Core :: Security: PSM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

There are lots of warnings in security/pkix which are suppressed with clang, but not clang-cl.
Blocks: 1476475
Comment on attachment 8992817 [details]
Bug 1476486 - Apply clang warning suppression in pkix to clang-cl as well.

https://reviewboard.mozilla.org/r/257650/#review264682

::: commit-message-4ec42:1
(Diff revision 1)
> +Bug 1476486 - Apply clang warning suppression in pkix to clang-cl as well. r?Build

I think we can just use the gcc/clang path instead of using both gcc/clang and msvc branches because clang-cl does not emulate msvc very well regarding the warning behavior. Clang-cl will just ignore most -wd**** switches, so we should avoid wasting the command line length that is a scare resource on Windows.
Attachment #8992817 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment on attachment 8992817 [details]
Bug 1476486 - Apply clang warning suppression in pkix to clang-cl as well.

https://reviewboard.mozilla.org/r/257650/#review264836
Attachment #8992817 - Flags: review?(nfroyd) → review+
Attachment #8992817 - Attachment is obsolete: true
Attachment #8993192 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment on attachment 8993192 [details]
Bug 1476486 - Apply clang warning suppression (rather than msvc) in pkix for clang-cl.

https://reviewboard.mozilla.org/r/257994/#review265110
Attachment #8993192 - Flags: review?(nfroyd) → review+
Thanks!
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf4b4cfa5159
Apply clang warning suppression (rather than msvc) in pkix for clang-cl. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/bf4b4cfa5159
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Thank you for fixing some of the warnings!
 

== Change summary for alert #14567 (as of Wed, 25 Jul 2018 08:34:36 GMT) ==

Improvements:

 31%  compiler warnings windows2012-32 opt rusttests     8,458.00 -> 5,863.00
 31%  compiler warnings windows2012-32 pgo               8,458.04 -> 5,863.00
 31%  compiler warnings windows2012-32 opt               8,458.00 -> 5,863.00
 31%  compiler warnings windows2012-64 pgo               8,505.08 -> 5,910.00
 31%  compiler warnings windows2012-64 opt               8,505.00 -> 5,910.00
 30%  compiler warnings windows2012-64 opt rusttests     8,505.00 -> 5,931.50
 28%  compiler warnings windows2012-32-noopt debug       9,431.00 -> 6,836.00
 28%  compiler warnings windows2012-32 debug             9,431.08 -> 6,836.00
 27%  compiler warnings windows2012-64-noopt debug       9,495.04 -> 6,900.00
 27%  compiler warnings windows2012-64 debug             9,495.00 -> 6,900.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=14567
You need to log in before you can comment on or make changes to this bug.