1476506 - mozilla::RoundedRect uses double precision

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Bas Schouten (:bas.schouten)]

This causes a bunch of pointless conversions, and means RoundedRect is defined outside of Moz2D. There's no need for that as far as I can tell. This patch addresses the issue.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1476506: Move RoundedRect into Moz2D and convert all callers.

Review commit: https://reviewboard.mozilla.org/r/257692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257692/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8992843 [details]
Bug 1476506: Move RoundedRect into Moz2D and convert all callers.

https://reviewboard.mozilla.org/r/257692/#review264574

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8992843 [details]
Bug 1476506: Move RoundedRect into Moz2D and convert all callers.

https://reviewboard.mozilla.org/r/257692/#review264576


Code analysis found 3 defects in this patch:
 - 3 defects found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: gfx/2d/Rect.h:347
(Diff revision 1)
>  }
>  
> +struct RectCornerRadii {
> +  Size radii[eCornerCount];
> +
> +  RectCornerRadii() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

  RectCornerRadii() {}
  ^                 ~~
                    = default;

::: gfx/2d/Rect.h:347
(Diff revision 1)
>  }
>  
> +struct RectCornerRadii {
> +  Size radii[eCornerCount];
> +
> +  RectCornerRadii() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

  RectCornerRadii() {}
  ^                 ~~
                    = default;

::: gfx/2d/Rect.h:347
(Diff revision 1)
>  }
>  
> +struct RectCornerRadii {
> +  Size radii[eCornerCount];
> +
> +  RectCornerRadii() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

  RectCornerRadii() {}
  ^                 ~~
                    = default;

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8580f0233058
Move RoundedRect into Moz2D and convert all callers. r=mattwoodrow

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8580f0233058