1476513 - add moz.yaml and license to vendored cld2 library

Status: RESOLVED DUPLICATE of bug 1800715

(Firefox :: Translations, enhancement, P5)

Description

[:glob ✱]

add moz.yaml and license to vendored cld2 library

Comment 1

[:glob ✱]

Attachment: Bug 1476513: add moz.yaml and LICENSE to vendored CLD2 library r=florian

Comment 2

[:glob ✱]

see https://blog.glob.com.au/2018/06/15/moz-yaml/ for the background.
i wasn't sure who to ask for a review.

Comment 3

[Florian Quèze [:florian]]

Looks like phabricator is not relaying comments to bugzilla, I wrote:

I'm not sure adding another license file in browser/components/translation/cld2 is the right thing to do, we already have a license file at browser/components/translation/cld2/internal/LICENSE. Should we maybe move it instead? I'm assuming you are trying to keep the same layout as the layout found in the github repository.

Inside the browser/components/translation/cld2 folder:
- the "internal" and "public" folders are code from the library.
- cld-worker.js and cld-worker.js.mem are the compiled result of the whole folder.
- the other files (post.js, cldapp.cc, cld.idl, Makefile) are our own MPL'ed code to make the cld library usable within Firefox.

Comment 4

[:glob ✱]

(In reply to Florian Quèze [:florian] from comment #3)
> Looks like phabricator is not relaying comments to bugzilla

thanks for the quick feedback.  not mirroring review comments to bugzilla is by design; i'll continue the dialog in phabricator :)

Comment 5

[Greg Tatum [:gregtatum]]

This is getting removed in Bug 1817084

Comment 6

[Greg Tatum [:gregtatum]]

Oh, it's already in there, this is a duplicate then.