147665 - M1RC3 crash [@ nsLocalFile::GetPath]

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[ly nguyen]

people have been crashing with mozilla rc3 opening a download link. below is the
latest info from talkback:

     Count   Offset    Real Signature
[ 4   nsLocalFile::GetPath efed3acd - nsLocalFile::GetPath ]
[ 4   nsLocalFile::GetPath e412e1ba - nsLocalFile::GetPath ]
[ 3   nsLocalFile::GetPath ec0407b7 - nsLocalFile::GetPath ]
[ 2   nsLocalFile::GetPath 42cc54ef - nsLocalFile::GetPath ]
[ 1   nsLocalFile::GetPath da541d47 - nsLocalFile::GetPath ]
[ 1   nsLocalFile::GetPath 6220436f - nsLocalFile::GetPath ]
 
     Crash date range: 2002-05-24 to 2002-05-27
     Min/Max Seconds since last crash: 86 - 77338
     Min/Max Runtime: 154 - 91475
     Keyword List :  
     Count   Platform List 
     11   Windows NT 5.0 build 2195
     4   Windows NT 5.1 build 2600
 
     Count   Build Id List 
     15   2002052308
 
     No of Unique Users        10
 
 Stack trace(Frame) 

	 nsLocalFile::GetPath
[d:\builds\seamonkey\mozilla\xpcom\io\nsLocalFileWin.cpp  line 2274] 
	 XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 106] 
	 XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line 2028] 
	 XPC_WN_GetterSetter
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1299] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 790] 
	 js_InternalInvoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 881] 
	 js_GetProperty
[d:\builds\seamonkey\mozilla\js\src\jsobj.c  line 2523] 
	 js_Interpret
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 2576] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 806] 
	 nsXPCWrappedJSClass::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappedjsclass.cpp  line 1195] 
	 nsXPCWrappedJS::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappedjs.cpp  line 430] 
	 PrepareAndDispatch
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcstubs.cpp 
line 117] 
	 SharedStub
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcstubs.cpp 
line 139] 
	 XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 106] 
	 XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line 2028] 
	 XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1267] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 790] 
	 js_Interpret
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 2744] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 806] 
	 js_InternalInvoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 881] 
	 JS_CallFunctionValue
[d:\builds\seamonkey\mozilla\js\src\jsapi.c  line 3426] 
	 nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp  line 1019] 
	 nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp  line 182] 
	 nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1220] 
	 nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1902] 
	 GlobalWindowImpl::HandleDOMEvent
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp  line 727] 
	 DocumentViewerImpl::LoadComplete
[d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp  line 1436] 
	 nsDocShell::EndPageLoad
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp  line 3887] 
	 nsWebShell::EndPageLoad
[d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp  line 731] 
	 nsDocShell::OnStateChange
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp  line 3801] 
	 nsDocLoaderImpl::FireOnStateChange
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp  line 1112] 
	 nsDocLoaderImpl::doStopDocumentLoad
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp  line 771] 
	 nsDocLoaderImpl::DocLoaderIsEmpty
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp  line 669] 
	 nsDocLoaderImpl::OnStopRequest
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp  line 600] 
	 nsLoadGroup::RemoveRequest
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsLoadGroup.cpp  line 531] 
	 nsJARChannel::OnStopRequest
[d:\builds\seamonkey\mozilla\netwerk\protocol\jar\src\nsJARChannel.cpp  line 612] 
	 nsOnStopRequestEvent::HandleEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsRequestObserverProxy.cpp  line 213] 
	 PL_HandleEvent
[d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c  line 597] 
	 PL_ProcessPendingEvents
[d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c  line 530] 
	 _md_EventReceiverProc
[d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c  line 1078] 
	 USER32.dll + 0x3c076 (0x77d7c076)  
	 USER32.dll + 0x3c076 (0x77d7c076)  
	 _except_handler3()  
	 kernel32.dll + 0x3bb86 (0x77e9bb86)   
 
     (6694760)	Comments: Tried to download a file from an FTP site.
     (6631489)	Comments: opening a download link in a new window
     (6624656)	URL: Netscape 7 prerelease download link.
     (6624656)	Comments: I was downloading netscape 7 prerelease 1 from netscape site

Comment 1

[ly nguyen]

i just installed m1rc3 (talkback_enabled_FullInstaller.exe a.k.a
mozilla-win32-1.0rc3-installer) on my windows 2000 machine but was unable to
reproduce this crash. my download of pr1 using rc3 from www.netscape.com went
smoothly.

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

This should fix the problem.

I think the problem is that we allocate some memory which is going to be used
passed out to a nsXPIDLString.	If the WideCharToMultiByte fails, the raw block
of memory passed back to the getter_Copies.  This is bad.

The patch frees and nulls the result if an error occurs.

Comment 3

[Shiva Thirumazhusai]

->topcrash+

Comment 4

[Darin Fisher]

Comment on attachment 85644 [details] [diff] [review]
patch v.1

looks good... any idea why this only shows up in RC3?  clearly it must be
fallout from my nsLocalFile changes, right?  but, i don't recall changing any
of the converter code... hmm.

Comment 5

[Doug Turner (:dougt)]

that fix was to new code which was landed part of the nsIFile/string changes.

Comment 6

[Shiva Thirumazhusai]

dougt, darin: who can do review ?

Comment 7

[Darin Fisher]

i already sr'd the patch.

Comment 8

[Doug Turner (:dougt)]

I sent mail to dveditz, but darin mentioned that alec knows this code better? 
Alec, can you review this?

Comment 9

[rpotts (gone)]

Comment on attachment 85644 [details] [diff] [review]
patch v.1

r=[e-mail]

Comment 10

[Shiva Thirumazhusai]

nominating for nsbeta1. Adding impact as [ADT1]. If anybody thinks otherwise
please go ahead and change it appropriately.

Comment 11

[Doug Turner (:dougt)]

Checking in nsLocalFileWin.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileWin.cpp,v  <--  nsLocalFileWin.cpp
new revision: 1.88; previous revision: 1.87
done

Comment 12

[chris hofmann]

Comment on attachment 85644 [details] [diff] [review]
patch v.1

a=chofmann for 1.0.1

Comment 13

[Doug Turner (:dougt)]

Checking in nsLocalFileWin.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileWin.cpp,v  <--  nsLocalFileWin.cpp
new revision: 1.82.4.6; previous revision: 1.82.4.5
done

Comment 14

[scottputterman]

removing adt1.0.1 since it was already checked in.  Please wait for adt approval
in the future.