1476702 - Login broken after update to Auth0-js 9.7.2

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Cameron Dawson [:camd]]

The parameter expected by ``parseHash`` changed from a string to an object.  So it's throwing an error on login to that effect.  Easy fix.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3800

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4fa8d8bb2ac6a4005c63019b6a7b3870accdb712
Bug 1476702 - Fix login broken after update to Auth0-js 9.7.2 (#3800)

Comment 3

[Cameron Dawson [:camd]]

Got an R+ in the PR itself.  So merged it.

Comment 4

[Ed Morley [:emorley]]

The recent auth-js update:
* was only a point release
* doesn't change the signature of the relevant method

As such it seems that:
1) perhaps this has been broken for a while, or else the reason for breakage in comment 0 is missing a detail
2) depending on (1) we should file an issue upstream (semver minor/patch should never cause breakage; though if we were using it wrong, then that's a grey area)

Comment 5

[Cameron Dawson [:camd]]

Looking at the source of Auth0-js, this function hasn't changed, as Ed mentioned.  So I'm a bit surprised that this started failing for us.  It appears that if ``options.hash`` was undefined (as it would have been for the string we passed in) then it got the hash directly from the ``window.location.hash``.

So, I think it is true that we were passing the wrong param all along and that it was falling back to getting it itself from ``window``.  Perhaps there is something deeper in the package that needed this, I haven't taken the time to dig that deep.  But this change is still the right one because we should have been passing an object to it all along.  Even back to version 9.6, it was expecting options to be either an object or a callback function.