1476716 - Crash in java.lang.SecurityException: COLUMN_LOCAL_FILENAME is deprecated; use ContentResolver.openFileDescriptor() instead at android.app.DownloadManager$CursorTranslator.getString(DownloadManager.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-3b43d4db-7fb6-4d34-bf09-6b25b0180718.
=============================================================

Possible regression from Bug 1407046: https://bit.ly/2JxesdK. The crash started in Build 20180717100050.

Java stack trace:

java.lang.SecurityException: COLUMN_LOCAL_FILENAME is deprecated; use ContentResolver.openFileDescriptor() instead
	at android.app.DownloadManager$CursorTranslator.getString(DownloadManager.java:1810)
	at org.mozilla.gecko.DownloadsIntegration$Download.fromCursor(DownloadsIntegration.java:75)
	at org.mozilla.gecko.DownloadsIntegration.removeDownload(DownloadsIntegration.java:206)
	at org.mozilla.gecko.DownloadsIntegration.handleMessage(DownloadsIntegration.java:96)
	at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:344)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:43)

Comment 1

[Jan Henning [:JanH]]

Probably bug 1473872, actually.

Comment 2

[Oana Horvath [:ohorvath]]

Reproduced this crash by deleting a bookmark from about:downloads on Nightly 07/19.
Devices:
Samsung Galaxy S8 (Android 8.0)
Nokia 6 (Android 7.1.1)
Huawei Nexus 6P (Android 8.1.0)

Not reproducing on: 
HTC Desire 820 (Android 6.0.1)

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1476716 - Use DownloadManager.COLUMN_LOCAL_URI to query downloads;

After API 24 DownloadManager.COLUMN_LOCAL_FILENAME got deprecated and querying
for it would throw an error.
To get around this DownloadManager.COLUMN_LOCAL_URI can be used but which adds
the "file://" prefix.

Review commit: https://reviewboard.mozilla.org/r/258154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258154/

Comment 4

[Oana Horvath [:ohorvath]]

*deleting a download from about:downloads, of course. Sorry for the confusion.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8993376 [details]
Bug 1476716 - Use DownloadManager.COLUMN_LOCAL_URI to query downloads;

https://reviewboard.mozilla.org/r/258154/#review265246

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0eac2c4ac99c
Use DownloadManager.COLUMN_LOCAL_URI to query downloads; r=jchen

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/0eac2c4ac99c

Comment 8

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 07/20.
Devices:
Google Pixel (Android P beta)
Samsung Galaxy S8 (Android 8.0)