Closed Bug 1476718 Opened 6 years ago Closed 6 years ago

Visual glitches with calendar twisties

Categories

(Calendar :: Lightning Only, defect)

Product:
Calendar
Component:
Lightning Only
Version:
Lightning 6.4
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(1 file)

lightning-twisty.patch
1.48 KB, patch
MakeMyDay
: review+
Details | Diff | Splinter Review 
Like already mentioned in bug 1476259, there is an issue with the twisty in the today pane - the collapsed and expanded twisty are diplayed both when only the expanded should be displayed - see alaso attach,ment 8992600.

Apart from that is the twisty (in the today pane and the calendar list) too large compared with TB e.g. in the folder list.

This is a regression from bug 1470740 and observed on Windows, maybe Linux and OSX are affected as well.
Flags: needinfo?(richard.marti)
Attached patch lightning-twisty.patch — — Splinter Review 
This was a copy/paste error. Now I also had to change the icon dimension rules to override the now on document loaded toolkit stylesheet (the twisty was too big).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #8993252 - Flags: review?(makemyday)
Comment on attachment 8993252 [details] [diff] [review]
lightning-twisty.patch

Review of attachment 8993252 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the swift patch. Looks good as the twisties do again. Do we need something similar for other platforms then Windows?
Attachment #8993252 - Flags: review?(makemyday)
Attachment #8993252 - Flags: review+
Attachment #8993252 - Flags: approval-calendar-beta?(philipp)
I checked the other platforms and they are looking correct.
Keywords: checkin-needed
Attachment #8993252 - Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/67048a6b1ab4
Fix the twisty in Lightning (regression of bug 1470740). r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
Attachment #8993252 - Flags: approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: