Closed Bug 1476733 Opened 3 years ago Closed 3 years ago

Missing ChromeUtils.generateQI conversion in calProviderUtils

Categories

(Calendar :: General, defect)

Lightning 6.4
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

References

Details

Attachments

(1 file)

Looks like an errornous conversion in bug 1458370 for [1]:

>Lightning: When generating QI for one interface, please use ChromeUtils.generateQI
>1: [resource://calendar/modules/calUtils.jsm:186] generateQI
>2: [resource://calendar/modules/calUtils.jsm:170] generateClassQI
>3: [resource://calendar/modules/utils/calProviderUtils.jsm:230] QueryInterface
>4: [file:///F:/workspace/mozilla/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calDavCalendar.js:2532] getFreeBusyIntervals/streamListener.onStreamComplete
>5: [file:///F:/workspace/mozilla/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calDavCalendar.js:360] oauthCheck
>6: [chrome://lightning/content/lightning-item-iframe.js:1833] editAttendees
>7: [chrome://lightning/content/lightning-item-iframe.js:189] receiveMessage


[1] https://searchfox.org/comm-central/source/calendar/base/modules/utils/calProviderUtils.jsm#230
This corrects the mentioned issue and another occurence.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Attachment #8994052 - Flags: review?(philipp)
Attachment #8994052 - Flags: review?(philipp) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e9b4a9b6c5ce
Add missing conversions to ChromeUtils.generateQI in calProviderUtils. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Please manage the beta request/approval yourself. I've not uplifted anything to beta since there is the possibility that TB 62 beta will be scrapped. Here's a list of uplifts I haven't done: https://mzl.la/2LQZ3Hd
Target Milestone: --- → 6.5
Comment on attachment 8994052 [details] [diff] [review]
FixRemainderOfGenerateQIConversion-V1.diff

If we build a TB 62 beta with Calendar 6.4 this will need uplift since it's broken in 6.4 if I can trust the Version/Tracking. I we don't set some sort of flag, it will be forgotten.
Attachment #8994052 - Flags: approval-calendar-beta+
Attachment #8994052 - Flags: approval-calendar-beta+ → approval-calendar-beta?(philipp)
Nothing is broken without that fix, since the request is forwarded to ChromeUtils.generateQI. This is just to silence a warning in the error console.
Comment on attachment 8994052 [details] [diff] [review]
FixRemainderOfGenerateQIConversion-V1.diff

No need to uplift this as per comment 5
Attachment #8994052 - Flags: approval-calendar-beta?(philipp) → approval-calendar-beta-
Attachment #8994052 - Flags: approval-calendar-beta-
You need to log in before you can comment on or make changes to this bug.