1476802 - toolkit/library/rust/Tupfile does not obey --dry-run

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Shal [:mshal]]

We call _get_backend_file during the TupBackend initialization for toolkit/library/rust/Tupfile, since all rust compilation ends up there. However, it appears that self.dry_run is not set at this point in the initialization, so this Tupfile is always written out, even if --dry-run is passed in to mach build-backend.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1476802 - Make toolkit/library/rust/Tupfile work with --dry-run;

We shouldn't call _get_backend_file during TupBackend:_init() since
self.dry_run is not set yet. Instead we can just call it when we need to
add rust rules.

Review commit: https://reviewboard.mozilla.org/r/257972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257972/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8993160 [details]
Bug 1476802 - Make toolkit/library/rust/Tupfile work with --dry-run;

https://reviewboard.mozilla.org/r/257972/#review264858

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/976212a3a35a
Make toolkit/library/rust/Tupfile work with --dry-run; r=cmanchester+432261

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/976212a3a35a