Closed Bug 1476802 Opened 2 years ago Closed 2 years ago

toolkit/library/rust/Tupfile does not obey --dry-run

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(1 file)

We call _get_backend_file during the TupBackend initialization for toolkit/library/rust/Tupfile, since all rust compilation ends up there. However, it appears that self.dry_run is not set at this point in the initialization, so this Tupfile is always written out, even if --dry-run is passed in to mach build-backend.
Comment on attachment 8993160 [details]
Bug 1476802 - Make toolkit/library/rust/Tupfile work with --dry-run;

https://reviewboard.mozilla.org/r/257972/#review264858
Attachment #8993160 - Flags: review+
Attachment #8993160 - Flags: review?(core-build-config-reviews)
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/976212a3a35a
Make toolkit/library/rust/Tupfile work with --dry-run; r=cmanchester+432261
https://hg.mozilla.org/mozilla-central/rev/976212a3a35a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.