Closed Bug 1476808 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 12058 - Revert "Adjusted references in tests to match new helper.sub.js file"

Categories

(Core :: DOM: Security, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Sync web-platform-tests PR 12058 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12058
Details from upstream follow.

Alex Moshchuk <alexmos@chromium.org> wrote:
>  Revert "Adjusted references in tests to match new helper.sub.js file"
>  
>  This reverts commit ac436aaa9d361c99dcf4df11bd11ad201a2bccd8.
>  
>  Reason for revert: 
>  Sorry for the revert, but this might be breaking some layout tests on 
>  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/71090 (see also a few subsequent builds)
>  
>  Failing tests include:
>   external/wpt/trusted-types/HTMLImageElement-src.tentative.html
>   external/wpt/trusted-types/HTMLMediaElement-src.tentative.html
>   external/wpt/trusted-types/HTMLSourceElement-src.tentative.html
>   external/wpt/trusted-types/block-string-assignment-to-HTMLImageElement-src.tentative.html
>   external/wpt/trusted-types/block-string-assignment-to-HTMLMediaElement-src.tentative.html
>   external/wpt/trusted-types/block-string-assignment-to-HTMLSourceElement-src.tentative.html
>  
>  Sample failure output (from external/wpt/trusted-types/HTMLImageElement-src.tentative.html, others are similar):
>  
>  This is a testharness.js-based test.
>  FAIL src = TrustedURL.create(). URLS is not defined
>  FAIL src = TrustedURL.unsafelyCreate(). URLS is not defined
>  Harness: the test ran to completion.
>  
>  
>  
>  Original change's description:
>  > Adjusted references in tests to match new helper.sub.js file
>  > 
>  > helper.js changed to helper.sub.js.
>  > URLS.safe modified to work with wpt.
>  > 
>  > Bug: 739170
>  > Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec
>  > Reviewed-on: https://chromium-review.googlesource.com/1141725
>  > Reviewed-by: Mike West <mkwst@chromium.org>
>  > Commit-Queue: Maja Kabus <kabusm@google.com>
>  > Cr-Commit-Position: refs/heads/master@{#576037}
>  
>  TBR=vogelheim@chromium.org,mkwst@chromium.org,kabusm@google.com
>  
>  Change-Id: Ieaa3bba36a970c7aa7547939c8f97a57a1b32544
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 739170
>  Reviewed-on: https://chromium-review.googlesource.com/1142165
>  Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
>  Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#576103}
>
PR 12058 applied with additional changes from upstream: 5834cfc29ec99cc30b3cb82a95ff52effd56a19d, 9e4a93afa661c4a6ecb39ce810fcc77d73cd6405, d886715e456fb9a2e23e310ceaf8f9edc38f24b2, bd2709244a313ed5ea8e08d83c22173955c1ed80, 4b0008b5230f13161ecf5a4ab01905af857bacdd, 0fd696381d8c02f0b635c415752dafe2ce0ba7e6
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Ran 26 tests and 73 subtests
OK     : 24
PASS   : 2
FAIL   : 71
TIMEOUT: 2

New tests that have failures or other problems:
/trusted-types/DOMParser-requiresTrustedTypes.tentative.html
    'innerTextOfDoc = null' throws: FAIL
    `innerTextOfDoc = string` throws.: FAIL
    innerTextOfDoc = TrustedHTML.escape().: FAIL
    innerTextOfDoc = TrustedHTML.unsafelyCreate().: FAIL
/trusted-types/DOMParser.tentative.html
    innerTextOfDoc = TrustedHTML.escape().: FAIL
    innerTextOfDoc = TrustedHTML.unsafelyCreate().: FAIL
/trusted-types/HTMLBaseElement-href.tentative.html
    base.href = URLS.safe, TrustedURL.create: FAIL
    base.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
/trusted-types/block-string-assignment-to-HTMLBaseElement-href.tentative.html
    `base.href = null` throws: FAIL
    `base.href = string` throws: FAIL
    base.href = URLS.safe, TrustedURL.create: FAIL
    base.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
/trusted-types/block-string-assignment-to-createContextualFragment.tentative.html
    DocumentFragment.textContent = TrustedHTML.escape().: FAIL
    DocumentFragment.textContent = TrustedHTML.unsafelyCreate().: FAIL
    `DocumentFragment.textContent = null` throws.: FAIL
    `DocumentFragment.textContent = string` throws.: FAIL
/trusted-types/block-string-assignment-to-location-assign.tentative.html: TIMEOUT
/trusted-types/block-string-assignment-to-location-replace.tentative.html: TIMEOUT
/trusted-types/createContextualFragment.tentative.html
    DocumentFragment.textContent = TrustedHTML.escape().: FAIL
    DocumentFragment.textContent = TrustedHTML.unsafelyCreate().: FAIL
/trusted-types/location-assign.tentative.html
    Basic processing: safe URL, safe construction.: FAIL
    Basic processing: safe URL, unsafe construction.: FAIL
/trusted-types/location-replace.tentative.html
    Basic processing: safe URL, safe construction.: FAIL
    Basic processing: safe URL, unsafe construction.: FAIL
/trusted-types/srcDoc-requiresTrustedTypes.tentative.html
    'srcdoc = string' throws.: FAIL
    srcdoc = TrustedHTML.escape().: FAIL
    srcdoc = TrustedHTML.unsafelyCreate().: FAIL
/trusted-types/srcDoc.tentative.html
    srcdoc = TrustedHTML.escape().: FAIL
    srcdoc = TrustedHTML.unsafelyCreate().: FAIL
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2a5c3a9eecd
[wpt PR 12058] - Revert "Adjusted references in tests to match new helper.sub.js file", a=testonly
https://hg.mozilla.org/mozilla-central/rev/b2a5c3a9eecd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.