Closed Bug 1476874 Opened 2 years ago Closed 2 years ago

Static libraries contain objects twice

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

I found this in my logs while debugging some unrelated LTO linkage issue:

rm -f libxpcomglue.a
/builds/worker/workspace/build/src/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-ar crs libxpcomglue.a FileUtils.o nsXPCOMGlue.o FileUtils.o nsXPCOMGlue.o

Fortunately, linkers don't care, but that's suboptimal.
Attachment #8993234 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment on attachment 8993234 [details]
Bug 1476874 - Only link object once in static libraries.

https://reviewboard.mozilla.org/r/258024/#review265106

Nice catch.
Attachment #8993234 - Flags: review?(nfroyd) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/d93096c59a0a
Only link object once in static libraries. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/d93096c59a0a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.