1476881 - FTS index for history_fts table isn't being rebuilt upon migration

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement, P1)

Description

[Isabel Rios[:isabel_rios]]

This commit 
https://github.com/mozilla-mobile/firefox-ios/commit/221759181eaa5ef83c537e5140b21142ecf7bfd2

is making this test fails:

https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/DomainAutocompleteTest.swift#L173

The way we implement the test is using DB with history entries so that we don't have to browser to the websites that we are using. Then, typing on the URL bar when there are matches the URL title should be shown.

Until that commit the test was working, but now no results are shown when typing an url, it only works if we don't use preloaded DB and go to visit the websites during the test.

The test can be modified so that instead of using the DB the webistes are visited but since it was working before thought it was worth mentioning just in case this could cause other issues/side effects on other tests or the app itself.

Comment 1

[Isabel Rios[:isabel_rios]]

ni you Justin, since that commit is regarding the changes in the awesomebar searches. Thanks!

Comment 2

[Isabel Rios[:isabel_rios]]

Attachment: WorkingBeforeWithPreloadedData.mov

Comment 3

[Isabel Rios[:isabel_rios]]

Attachment: FailurePreloadedDB.mov

Comment 4

[Isabel Rios[:isabel_rios]]

Attachment: HowItWouldWorkWithoutDB.mov

Comment 5

[Justin D'Arcangelo [:justindarc]]

Renaming to clarify the root cause of the test failure.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 7

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8993417 [details]
GitHub Pull Request

Carrying over R+ from GitHub.

Comment 8

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/c2b68a1ef1d2627db5e02918ed8e46ef238d284d